Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TabNav] TypeError when used inside Panel #6310

Closed
benelan opened this issue Jan 19, 2023 · 3 comments
Closed

[TabNav] TypeError when used inside Panel #6310

benelan opened this issue Jan 19, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers.
Milestone
2023 January Prio...

Comments

@benelan
Copy link
Member

benelan commented Jan 19, 2023

Actual Behavior

There is a type error when using Tabs inside of Panel

p-4c5a1247.entry.js:6 Uncaught TypeError: Cannot read properties of undefined (reading 'style')
at ResizeObserver.

Expected Behavior

There should not be a TypeError when using Tabs inside of Panel

Reproduction Sample

https://codepen.io/fcbasson/pen/KKByZzV

Reproduction Steps

  1. Open the repro sample and check the console

Reproduction Version

next.728

Relevant Info

This was reported on Esri Community:
https://community.esri.com/t5/calcite-design-system-questions/calcite-tabs-creating-resizeobserver-type-error/m-p/1249383#M290

Here is the line causing issues:
https://github.com/esri/calcite-components/blob/f146a0991799c1d44261bb808fc05c54515f78d2/src/components/tab-nav/tab-nav.tsx#L307

Regression?

No response

Impact

No response

Esri team

Calcite (dev)
@benelan benelan added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 19, 2023
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Jan 19, 2023
@AdelheidF
Copy link

also reproducible with next.716

@jcfranco jcfranco self-assigned this Jan 25, 2023
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Jan 25, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 25, 2023
@jcfranco jcfranco mentioned this issue Jan 25, 2023
Merged
@macandcheese macandcheese mentioned this issue Jan 30, 2023
Closed
jcfranco added a commit that referenced this issue Jan 30, 2023
@jcfranco
fix(tabs): fix error when tabs is resized before initial render (#6342)
a2ba64e 
**Related Issue:** #6310

## Summary

This prevents resize logic from running if the indicator element has not
been rendered and stored internally.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 30, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Jan 30, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 31, 2023
@geospatialem
Copy link
Member

Verified in 1.0.4-next.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers.
Projects
None yet
Milestone
2023 January Priorities Patch - Bugs ...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @benelan @AdelheidF