Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calcite-input-date-picker]: should display placeholder text when the value is reset to null #6378

Closed
vannizhang opened this issue Jan 30, 2023 · 3 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@vannizhang
Copy link
Member

vannizhang commented Jan 30, 2023

Actual Behavior

I have two simple simple components, a calcite-input-date-picker and a calcite-button:
cal1

I can use the date picker to select a date without any issue:
cal2

The selected date should be reset when I click on the reset button, and I can see selected date become unselected in the calendar component after clicking the button:
cal3

But the input still shows previously selected date even after we reset the selected date:
cal4

Expected Behavior

the input should show placeholder text (e.g. YYYY/MM/DD) once the selected date is reset to undefined, so that the user knows that they have successfully reset the selected date.

Reproduction Sample

https://codepen.io/vannizhang/pen/ZEjMLaL?editors=1010

Reproduction Steps

open the codepen sample,
select a date using the date-picker component and you should see the selected date in input-date-picker
click on reset selected date button
you still see the previously selected date in the input-date-picker, which is incorrect, should see the placeholder text

Reproduction Version

1.0.3

Relevant Info

No response

Regression?

No response

Impact

The Living Atlas Curation App (a internal tool to curate all Living Atlas contents) uses the calcite-input-date-picker in a Modal to let the curator to select a auto removal date for any Living Atlas content, we also gives them a button to reset the previously selected auto removal date, when that button is clicked, we want them to see that change in the calcite-input-date-picker:

cal5

Esri team

Calcite (dev)

@vannizhang vannizhang added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 30, 2023
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Jan 30, 2023
@brittneytewks brittneytewks added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Apr 11, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Apr 11, 2023
@brittneytewks brittneytewks added the estimate - 3 A day or two of work, likely requires updates to tests. label May 25, 2023
@driskull driskull self-assigned this Jun 8, 2023
@geospatialem
Copy link
Member

Also surfaced in a Community post on June 9.

driskull added a commit that referenced this issue Jun 14, 2023
…e value (#7156)

**Related Issue:** #6378

## Summary

- Updates internal input's value when the value on the input-date-picker
is changed.
- Adds a test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jun 14, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Jun 14, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 26, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

5 participants