Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-date-picker): Fix showing the placeholder when resetting the value #7156

Merged
merged 3 commits into from
Jun 14, 2023
Merged

fix(input-date-picker): Fix showing the placeholder when resetting the value #7156

merged 3 commits into from
Jun 14, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Jun 8, 2023

Related Issue: #6378

Summary

  • Updates internal input's value when the value on the input-date-picker is changed.
  • Adds a test

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 8, 2023
@driskull driskull marked this pull request as ready for review June 8, 2023 21:07
@driskull driskull requested a review from a team as a code owner June 8, 2023 21:07
@driskull driskull requested review from eriklharper and a team June 12, 2023 22:06
eriklharper
eriklharper approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Such a smaller diff too :)

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 14, 2023
@driskull driskull merged commit 8d60ffd into master Jun 14, 2023
@driskull driskull deleted the dris0000/input-date-picker-reset-fix branch June 14, 2023 23:57
@github-actions github-actions bot added this to the 2023 June patch priorities milestone Jun 14, 2023
@calcite-admin calcite-admin mentioned this pull request Jun 14, 2023
Merged
benelan added a commit that referenced this pull request Jun 15, 2023
@benelan
Merge remote-tracking branch 'origin/master' into benelan/react-auto-…
1b7607f 
…import

* origin/master: (30 commits)
  chore: release next
  fix(radio-button, radio-button-group): prevent emitting events when selecting a checked radio button (#7102)
  feat(list): Add slots for filter actions (#7148)
  chore: release next
  fix(tooltip): improve component timing (#7172)
  chore: release next
  fix(input-date-picker): Fix showing the placeholder when resetting the value (#7156)
  chore: release next
  fix(input,input-number): allow typing decimal separator in firefox for arabic locale (#7173)
  build(deps): Bump workbox-build from 6.5.4 to 7.0.0 (#7167)
  build(deps): Bump type-fest from 3.5.0 to 3.11.1 (#7169)
  build(deps): Bump chromatic from 6.17.4 to 6.19.5 (#7171)
  build(deps): Bump @floating-ui/dom from 1.2.9 to 1.3.0 in /packages/calcite-components (#7168)
  build(deps): Bump @esri/calcite-ui-icons from 3.22.9 to 3.23.1 in /packages/calcite-components (#7166)
  build: update browserslist db (#7162)
  ci(release-please): change PR title and ensure git tag consistency (#7153)
  docs(changelog): Update commit message for #7160 (#7161)
  chore: release next
  fix(list): Improve border styling (#7160)
  chore: release next
  ...
benelan added a commit that referenced this pull request Jun 27, 2023
@calcite-admin @github-actions @benelan
chore: release latest (#7144)
2422120 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.4.3</summary>

##
[1.4.3](https://github.com/Esri/calcite-components/compare/@esri/calcite-components@1.4.2...@esri/calcite-components@1.4.3)
(2023-06-26)

### Bug Fixes

* **accordion-item:** support items working across shadowDOM ([#7035](#7035)) ([6378e35](6378e35)), closes [#6167](#6167)
* **alert:** Sets autoCloseDuration to "medium" by default
([#7157](#7157))
([1b9a8ed](1b9a8ed))
* **alert:** Update alert queue when an alert is removed from the DOM
([#7189](#7189))
([edd59eb](edd59eb))
* **combobox, dropdown, input-date-picker, input-time-picker, popover,
tooltip:** Prevent repositioning from affecting other floating
components
([#7178](#7178))
([1b02dae](1b02dae))
* Ensure mouse events are blocked for disabled components in Firefox
([#7107](#7107))
([271d985](271d985))
* **input-date-picker:** Fix showing the placeholder when resetting the
value ([#7156](#7156))
([8d60ffd](8d60ffd))
* **input, input-number:** Allows numeric characters.
([#7213](#7213))
([739f0af](739f0af))
* **input,input-number:** Allow typing decimal separator in firefox for
arabic locale
([#7173](#7173))
([595e6f2](595e6f2))
* **list:** No longer has incorrect border width
([a810943](a810943))
* **list:** Update selectedItems property on all item selection changes
([#7204](#7204))
([da048f6](da048f6))
* **menu-item:** Ensure correct order of rendered icons ([#7098](#7098)) ([fd344e9](fd344e9)), closes [#7097](#7097)

* **navigation:** Label is no longer a required property
([#7084](#7084))
([ba2bd4d](ba2bd4d))
* **radio-button-group:** No longer focus first radio button on label
click and adds `setFocus` method.
([#7050](#7050))
([4267b8c](4267b8c))
* **radio-button, radio-button-group:** Prevent emitting events when
selecting a checked radio button
([#7102](#7102))
([77fcc81](77fcc81))
* **radio-button:** Focuses first focusable radio-button element in
group. ([#7152](#7152))
([dd7ec60](dd7ec60))
* **scrim:** Responsively set the scale of the loading spinner
([#7182](#7182))
([72c5943](72c5943))
* **tooltip:** Improve component timing
([#7172](#7172))
([106f5d2](106f5d2))
* **tree-item:** Ensure expanded tree-item is displayed when expanded
and made visible
([#7216](#7216))
([3c0fbf5](3c0fbf5))

<details><summary>@esri/calcite-components-react: 1.4.3</summary>

##
[1.4.3](https://github.com/Esri/calcite-components/compare/@esri/calcite-components-react@1.4.2...@esri/calcite-components-react@1.4.3)
(2023-06-26)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 1.4.3-next.7 to 1.4.3
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklharper eriklharper eriklharper approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2023 June patch priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @eriklharper