Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shell] Add "panel-top" slot, rename "center-row" to "panel-bottom" #6389

Closed
macandcheese opened this issue Jan 31, 2023 · 2 comments
Closed

[Shell] Add "panel-top" slot, rename "center-row" to "panel-bottom" #6389

macandcheese opened this issue Jan 31, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 April Priori...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jan 31, 2023 •
edited
Loading

Description

Following up with more issues from proposals...

Acceptance Criteria

Rename "center-row" slot to "panel-bottom" to be more consistent with existing slot names.
Keep the existing "center-row" for a period of deprecation before removal.
Add a reciprocal "panel-top" slot.
Handle collision between these in the same way "panel-start/end" are.
Relevant Info

In future updates, Shell Panel will be the recommended component for use in these two slots (replacing Shell Center Row).

Which Component

Shell

Example Use Case

Slotted content is desired at the top of a shell component.

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 31, 2023
@macandcheese macandcheese self-assigned this Jan 31, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Jan 31, 2023
This was referenced Feb 9, 2023
Closed
Closed
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 27, 2023
@alisonailea alisonailea assigned driskull and unassigned driskull Feb 28, 2023
@brittneytewks brittneytewks added the p - medium Issue is non core or affecting less that 60% of people using the library label Mar 30, 2023
@geospatialem geospatialem assigned macandcheese and unassigned driskull Apr 4, 2023
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed p - medium Issue is non core or affecting less that 60% of people using the library labels Apr 4, 2023
@geospatialem geospatialem mentioned this issue Apr 4, 2023
Closed
@macandcheese macandcheese mentioned this issue Apr 4, 2023
Merged
macandcheese added a commit that referenced this issue Apr 6, 2023
@macandcheese
feat(shell): Add panel-top slot (#6730)
62fb8a2 
**Related Issue:** #6389 

## Summary
Adds a slot for positioning content at the top of the center area of a
Shell. As part of the larger set of layout updates (#6449), this will
eventually be a use case for Shell Panel.

For now, this will continue to use the Shell Center Row, just like the
`center-row` slot. That slot has been "deprecated" (as much as you can
deprecate a slot), and a new `panel-bottom` slot has been added.

This has some of the same "swim lane" configuration corners as the
current Shell Panel when combining `detached` without `content-behind`,
but those exist already and will be alleviated with documentation and
further component enhancements.

![Screen Shot 2023-04-04 at 12 52 16
PM](https://user-images.githubusercontent.com/4733155/229909815-d33078d5-20c8-45c1-9ba5-b1c5fcd9484f.png)
![Screen Shot 2023-04-04 at 12 51 40
PM](https://user-images.githubusercontent.com/4733155/229909816-fe7c7983-51d9-42b6-853c-fc20b296c911.png)
![Screen Shot 2023-04-04 at 12 51 30
PM](https://user-images.githubusercontent.com/4733155/229909818-0307cf41-a9cc-4482-a853-9a8c828b1134.png)
![Screen Shot 2023-04-04 at 12 52 29
PM](https://user-images.githubusercontent.com/4733155/229913196-3984016a-a510-43f1-867c-2420b250f951.png)
![Screen Shot 2023-04-04 at 1 21 06
PM](https://user-images.githubusercontent.com/4733155/229912220-f416c24d-4fc1-4dbb-afb0-7a9a9e36b106.png)
![Screen Shot 2023-04-04 at 1 20 43
PM](https://user-images.githubusercontent.com/4733155/229912224-5b8f4f6d-ade9-4819-b526-a13aec26f80d.png)

cc @driskull @asangma
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 6, 2023
@macandcheese macandcheese removed their assignment Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Apr 13, 2023
@geospatialem
Copy link
Member

Verified in 1.3.0-next.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 April Priorities - No breaking c...
Development

No branches or pull requests
5 participants
@driskull @alisonailea @macandcheese @geospatialem @brittneytewks