fix(block, date-picker, list-item-group, panel, pick-list-group, popover, tip, tip-manager)!: Set default internal heading to a div. #5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
added
the
pr ready for visual snapshots
|
Devs will need to update their code to preserve heading levels, so this would be a breaking change, right? |
jcfranco
reviewed
Nov 10, 2022
t9nmanifest.txt
Outdated
| @@ -29,4 +29,4 @@ src\components\shell-panel\assets\shell-panel\t9n | |||
| src\components\time-picker\assets\time-picker\t9n | |||
| src\components\tip-manager\assets\tip-manager\t9n | |||
| src\components\tip\assets\tip\t9n | |||
| src\components\value-list\assets\value-list\t9n | |||
There was a problem hiding this comment.
Can you revert this unrelated change?
Yes, I guess that would be a breaking change if they were not setting any value. |
driskull
changed the title
driskull
changed the title
driskull
changed the title
|
Updated to breaking change. |
driskull
removed
the
pr ready for visual snapshots
driskull
added
the
pr ready for visual snapshots
jcfranco
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Awesome!
Looks like we need a test helper for components + heading levels. Can you create a follow-up issue for this? I think we could add something simple that takes a component + a selector and it asserts internally on headingLevel not being set and when set.
|
Created issue: #5768 |
benelan
added a commit
that referenced
this pull request
Nov 16, 2022
* master: (24 commits) 1.0.0-next.632 feat(pick-list, value-list): Add calciteListFilter event, filteredItems prop, filterText prop and filteredData prop. (#5681) fix(block, date-picker, list-item-group, panel, pick-list-group, popover, tip, tip-manager)!: Set default internal heading to a div. (#5728) refactor(modal): Update modal to use focus-trap module. (#5676) 1.0.0-next.631 fix(input-date-picker): restores mouse clicks on date-picker popup (#5760) build(deps): bump loader-utils from 1.4.1 to 1.4.2 (#5764) ci(product-label): fix version syntax and use os agnostic newline char (#5762) 1.0.0-next.630 ci(pr-bot): don't label dependabot PRs (#5759) build(deps): bump chromatic from 6.7.1 to 6.11.4 (#5756) fix(combobox): Wrap and break text on long items (#5672) build(deps): bump @storybook/addon-interactions from 6.5.9 to 6.5.13 (#5753) build(deps): bump type-fest from 3.1.0 to 3.2.0 (#5752) build(deps): bump @storybook/addon-a11y from 6.5.12 to 6.5.13 (#5754) build(deps): bump postcss from 8.4.18 to 8.4.19 (#5755) ci: add chromatic (#5733) build(docs): generate docs-json for afd usage (#5748) 1.0.0-next.629 fix(inline-editable): Add text-ellipsis when not editing (#5679) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5099
Summary
fix(block, date-picker, list-item-group, panel, pick-list-group, popover, tip, tip-manager)!: Set default internal heading to a div.