Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): Wrap and break text on long items #5672

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

driskull
Copy link
Member

Related Issue: #5419

Summary

fix(combobox): Wrap and break text on long items. (#5419)

@driskull driskull requested a review from a team as a code owner October 31, 2022 22:26
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 8, 2022
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 10, 2022
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 10, 2022
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 14, 2022
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 14, 2022
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎁

@driskull driskull merged commit 4a4d776 into master Nov 15, 2022
@driskull driskull deleted the dris0000/combobox-long-items-break branch November 15, 2022 19:16
benelan added a commit that referenced this pull request Nov 16, 2022
* master: (24 commits)
  1.0.0-next.632
  feat(pick-list, value-list): Add calciteListFilter event, filteredItems prop, filterText prop and filteredData prop. (#5681)
  fix(block, date-picker, list-item-group, panel, pick-list-group, popover, tip, tip-manager)!: Set default internal heading to a div. (#5728)
  refactor(modal): Update modal to use focus-trap module. (#5676)
  1.0.0-next.631
  fix(input-date-picker): restores mouse clicks on date-picker popup (#5760)
  build(deps): bump loader-utils from 1.4.1 to 1.4.2 (#5764)
  ci(product-label): fix version syntax and use os agnostic newline char (#5762)
  1.0.0-next.630
  ci(pr-bot): don't label dependabot PRs (#5759)
  build(deps): bump chromatic from 6.7.1 to 6.11.4 (#5756)
  fix(combobox): Wrap and break text on long items (#5672)
  build(deps): bump @storybook/addon-interactions from 6.5.9 to 6.5.13 (#5753)
  build(deps): bump type-fest from 3.1.0 to 3.2.0 (#5752)
  build(deps): bump @storybook/addon-a11y from 6.5.12 to 6.5.13 (#5754)
  build(deps): bump postcss from 8.4.18 to 8.4.19 (#5755)
  ci: add chromatic (#5733)
  build(docs): generate docs-json for afd usage (#5748)
  1.0.0-next.629
  fix(inline-editable): Add text-ellipsis when not editing (#5679)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants