Skip to content

Commit

Permalink
fix(angular): publish from the dist directory (#8151)
Browse files Browse the repository at this point in the history
**Related Issue:** #7860

## Summary

Angular has an unusual workflow where you need to `cd` into the
library's `dist` directory and run `npm publish` from there. I found
related Lerna issues that culminated in the ability to publish a
particular package from a different directory. This is the doc I found
for the config option:

https://github.com/lerna/lerna/tree/main/libs/commands/publish#publishconfigdirectory

Unfortunately, it didn't end up working, so `v1.10.1-next.3` of the
angular wrapper is broken. I'm not aware of a way to test the results of
`lerna publish` without actually publishing.

I ended up copying the config from the `arcgis-web-components` repo's
angular wrapper once I remembered they use Lerna.
  • Loading branch information
benelan committed Nov 9, 2023
1 parent 4ef8b67 commit d813f14
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 63 deletions.
62 changes: 3 additions & 59 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,20 @@
"peerDependencies": {
"@angular/common": "^16.2.0",
"@angular/core": "^16.2.0",
"@esri/calcite-components": "1.10.0"
"@esri/calcite-components": "1.10.1-next.3"
},
"devDependencies": {
"@esri/calcite-components": "1.10.0"
"@esri/calcite-components": "1.10.1-next.3"
},
"dependencies": {
"tslib": "2.3.0"
},
"publishConfig": {
"directory": "./dist"
"lerna": {
"command": {
"publish": {
"directory": "./dist"
}
}
},
"license": "SEE LICENSE.md"
}

0 comments on commit d813f14

Please sign in to comment.