Remove border conflicts with backgrounds — Update border vars

[bstifle]

[macandcheese]

Is this a calcite-colors level or tailwind-level change?

[bstifle]

i think tailwind. the colors used for the new ones are existing in calcite colors

[macandcheese]

OK, I think we actually need to update this in calcite-colors repo - the values are there: https://github.com/Esri/calcite-colors/blob/ba782b1a87deb3ef6b5e98662220f24c0e40703c/dist/colors.scss#L528

[caripizza]

@bstifle does this need to land with v1.0.0?

[bstifle]

Ideally yes. Im not sure if it would be a breaking change or not

[caripizza]

@bstifle Got it, can you open an issue in that repository to get these colors updated then?

It sounds like these are the changes you're requesting right?

Sass var theme changes	OLD	NEW
Light theme
	$ui-border-2-light: #dfdfdf	#d4d4d4
	$ui-border-3-light: #eaeaea	#dfdfdf
Dark theme
	$ui-border-1-dark: #4a4a4a	#555555
	$ui-border-2-dark: #404040	#4a4a4a
	$ui-border-3-dark: #353535	#404040

[caripizza]

@driskull @jcfranco @paulcpederson looks like we're going to need to update the Sass variables' hex values in the table above over in calcite-colors. Then, cut a new release and consume that version here in cc.

Should all issues tied to this effort (ie., in both repos) have a "breaking change" label?

[driskull]

Should all issues tied to this effort (ie., in both repos) have a "breaking change" label?

Yes, if they are breaking changes. I'm not sure the calcite-components would be breaking though.

[paulcpederson]

yeah we'd have to update the theme mixins in calcite-colors to change these. Theoretically no updates on the calcite components side should be required other than updating the calcite colors lib?

[caripizza]

Thanks @driskull and @paulcpederson! Sounds like the calcite-colors issue would want the breaking change label then, not a big difference with those values in cc.

[caripizza]

Esri/calcite-colors#71 has been installed, just need to cut a new release. I'll work with Paul on this after next week. (Then we can use this issue to track consuming the updated version.)

[macandcheese]

What's the status of this? Would be great to get the correct values in there, it's a little weird now when switching between dark and light theme in a UI: https://jmp.sh/k0OOfHQ

[caripizza]

@macandcheese just waiting on a new release of calcite-colors per my comment in the linked issue cc @paulcpederson

[julio8a]

I can help publish. I'm looking at the latest for calcite-colors and it's 6.0.0, same as on NPM. Does that need to be updated before publishing a new version?

[driskull]

I can help publish. I'm looking at the latest for calcite-colors and it's 6.0.0, same as on NPM. Does that need to be updated before publishing a new version?

Yes.

[driskull]

https://github.com/Esri/calcite-colors/blob/master/CONTRIBUTE.md#releasing-a-version

[caripizza]

Verified on 1.0.0-next.266, the new border var values appear as:

.calcite-theme-light {
  ...
  --calcite-ui-border-2: #d4d4d4; /* (was #dfdfdf) */
  --calcite-ui-border-3: #dfdfdf; /* (was #eaeaea) */
  ...
}
  
.calcite-theme-dark {
  ...
  --calcite-ui-border-1: #555555; /* (was #4a4a4a) */
  --calcite-ui-border-2: #4a4a4a; /* (was #404040) */
  --calcite-ui-border-3: #404040; /* (was #353535) */
  ...
}