Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcite-slider > layout vertical and horizontal #5522

Open
SaschaBrunnerCH opened this issue Oct 19, 2022 · 8 comments
Open

calcite-slider > layout vertical and horizontal #5522

SaschaBrunnerCH opened this issue Oct 19, 2022 · 8 comments
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. c-slider Issues that pertain to the calcite-slider component design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.

Comments

@SaschaBrunnerCH
Copy link

Description

It should be possible to use the slider vertical. Like it is possible with the ArcGIS JS API Slider: https://developers.arcgis.com/javascript/latest/api-reference/esri-widgets-Slider.html#layout

image

Acceptance Criteria

Possible to configure the layout:

  • horizontal
  • horizontal-reversed
  • vertical
  • vertical-reversed

Relevant Info

See: https://developers.arcgis.com/javascript/latest/api-reference/esri-widgets-Slider.html#layout

Which Component

calcite-slider

Example Use Case

For a sample app we would like to include a slider to select the floor. For that purpose it should be vertical:

Example with the horizontal slider:
slider-floor

Esri team

ArcGIS API for JavaScript

@SaschaBrunnerCH SaschaBrunnerCH added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Oct 19, 2022
@github-actions github-actions bot added the ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. label Oct 19, 2022
@richiecarmichael
Copy link

This feature is required for:
#46032 Range Slider

The JSAPI Range Slider will be used by MapViewer to assign values to multi-dimensional rasters.

// @driskull @jcfranco

@ubatsukh
Copy link

@driskull as we discussed yesterday this is a high priority issue for us! MV needs Range Slider for multidimensional image services and the API implementation cannot proceed until the calcite slider has support for this.

@driskull driskull added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Nov 30, 2022
@brittneytewks brittneytewks added the design Issues that need design consultation prior to development. label Mar 22, 2023
@brittneytewks
Copy link

Start work in April (relate to #5827)

@brittneytewks brittneytewks added estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Mar 22, 2023
@geospatialem geospatialem added the c-slider Issues that pertain to the calcite-slider component label Mar 22, 2023
@ashetland ashetland self-assigned this Mar 29, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@ashetland
Copy link

Hey folks, see the below for a proposed vertical layout Slider. In addition to layout=vertical, this outlines direction-reversed and labels-reversed. I haven't included range and histogram here, but they'd follow the same logic. Figma file available for more details.
Slice 1
Slice 2

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Apr 6, 2023
@geospatialem
Copy link
Member

Priority has shifted to a medium status, with Maps SDK shifting priority to #6590 and #6591.

@ashetland ashetland self-assigned this Jul 18, 2023
@ashetland
Copy link

See this Figma file for designs for vertical Slider. Designs account for a new layout="horizontal | vertical" prop (horizontal would be the default), what it looks like when mirrored is set, as well as a new label-mirrored prop.

label-mirrored may not be needed, but it seemed appropriate to document since the placement of a vertical slider might necessitate an option for placing labels on the opposite side of the slider. Also documented is what that would look like in horizontal.

@ashetland ashetland added the ready for dev Issues ready for development implementation. label Jul 19, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 19, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@github-actions github-actions bot removed this from the Design Sprint milestone Jul 19, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit label Dec 12, 2023
@geospatialem geospatialem added estimate - 5 A few days of work, definitely requires updates to tests. and removed estimate - 3 A day or two of work, likely requires updates to tests. labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. c-slider Issues that pertain to the calcite-slider component design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

9 participants