-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calcite-slider > decouple ticks, labels and stops #5827
Comments
@driskull can you please change the priority of this issue to high as MV is asking for dimension/range slider. @jcfranco, we hope you can work the slider issues when you get back from your paternity leave. :) The other slider issues that need to be addressed before the Ranger slider widget can be implemented in the API: Here are the API requirements for the Range Slider: https://devtopia.esri.com/WebGIS/arcgis-js-api/issues/46032#issuecomment-3805946 |
@ubatsukh marked them as higher priority. We will figure out which milestone these can be taken care of after the 1.0 release. |
Better understand user priority. Start in April for future milestone implementation |
Apologies for the belated update, but I think I have an idea on how to implement this without introducing a breaking change. This is what it could look like: class Slider {
ticks: number | number[];
labelTicks: boolean | number[];
step: number | number[];
} Worth noting that we cannot rely entirely on arrays for these properties because they would prevent users from setting these in markup (we don't support passing rich data as attributes, see https://web.dev/articles/custom-elements-best-practices#aim-to-only-accept-rich-data-objects,-arrays-as-properties for more info). I'm planning to sync up with @richiecarmichael and also have some additional time for testing. With that said, this would have to be pushed to December. |
Bumped the priority on this one. cc @brittneytewks @geospatialem |
Additional efforts are needed to address prior to landing the fix, which are now targeted for the January 2024 release. |
Description
At present
calcite-slider
assumes that ticks, tick labels and stops coincide and that all three are at regular intervals. This is rarely the case. The solution is to have independent properties for all three. For examples:What are Labels?
Label will consist of text and longer tick mark, See #2584 for proposal on custom label formatter.
Design
Breaking changes:
slider.labelTicks
is obsoleteslider.ticks
changes fromnumber
tonumber[]
// @driskull @jcfranco
Acceptance Criteria
See above.
Relevant Info
Related issues:
#5522 - calcite-slider > layout vertical and horizontal
#2584 - Enhancement: calcite-slider - custom tick label formatters
#1631 - Enhancement: Configurable slider highlighting
Which Component
calcite-slider
Example Use Case
Esri team
ArcGIS API for JavaScript
The text was updated successfully, but these errors were encountered: