Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alert): auto-dismissable pauses timer while there is a focus on an element inside alert component #5960

Closed
Elijbet opened this issue Dec 9, 2022 · 2 comments
Closed

fix(alert): auto-dismissable pauses timer while there is a focus on an element inside alert component #5960

Elijbet opened this issue Dec 9, 2022 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. c-alert Issues that pertain to the calcite-alert component Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-06-25 - Jun ...

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Dec 9, 2022 •
edited
Loading

Description

Follow-up fix to #5872

While the timer pauses when hovering over, it's not pausing when the focus is inside the alert and the cursor is not. For instance, if a slotted calcite-link has focus, the timer should pause as well.

Also small refactors to rename private handle events for onPointerOut and onPointerOver handlers and corresponding tests.

Acceptance Criteria

auto-dismissable pauses timer while there is a focus on an element inside alert component

Relevant Info

No response

Which Component

alert

Example Use Case

No response

Esri team

Calcite (dev)
@Elijbet Elijbet added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 9, 2022
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Dec 9, 2022
@Elijbet Elijbet self-assigned this Dec 9, 2022
@geospatialem geospatialem mentioned this issue Dec 9, 2022
Closed
@geospatialem geospatialem mentioned this issue Jan 3, 2023
Closed
@Elijbet Elijbet assigned macandcheese and unassigned Elijbet Jan 5, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@macandcheese macandcheese removed their assignment Apr 3, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. 0 - new New issues that need assignment. and removed needs triage Planning workflow - pending design/dev review. 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 18, 2023
@geospatialem geospatialem added the a11y Issues related to Accessibility fixes or improvements. label Jan 10, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 10, 2024
@macandcheese macandcheese added the c-alert Issues that pertain to the calcite-alert component label May 1, 2024
@josercarcamo josercarcamo self-assigned this May 24, 2024
@josercarcamo josercarcamo mentioned this issue Jun 3, 2024
Merged
@josercarcamo josercarcamo added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 3, 2024
josercarcamo added a commit that referenced this issue Jun 5, 2024
@josercarcamo
fix(alert): pause auto-close alert when link focused (#9503)
fa9a829 
**Related Issue:** #5960 

## Summary
Paused auto close when the focus is in the link or close buton or when the mouse is hovered over the alert dialog.
@josercarcamo josercarcamo added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 6, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned josercarcamo Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 6, 2024
@geospatialem
Copy link
Member

Verified in 2.9.1-next.3:

verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. c-alert Issues that pertain to the calcite-alert component Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
6 participants
@alisonailea @macandcheese @geospatialem @Elijbet @DitwanP @josercarcamo