Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action-menu: implement OpenCloseComponent interface #6017

Open
Elijbet opened this issue Dec 13, 2022 · 0 comments
Open

Action-menu: implement OpenCloseComponent interface #6017

Elijbet opened this issue Dec 13, 2022 · 0 comments
Assignees
@Elijbet
Labels
1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-08-27 - Aug ...

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Dec 13, 2022

Description

action-menu uses popover internally, and it will need to handle emitting its own events on transition sequence.

Implement OpenCloseComponent interface with the new pattern where onToggleOpenCloseComponent replaces both connectOpenCloseComponent and disconnectOpenCloseComponent.

Proposed Advantages

This will make it consistent with the rest of the components that use openCloseComponent util pattern as a means to handle emitting on transition sequence.

Components that currently implement it are:
Alert
Combobox
Dropdown
Input-Date-Picker
Modal
Popover
Tooltip

Which Component

action-menu

Relevant Info

No response
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 13, 2022
@Elijbet Elijbet self-assigned this Dec 13, 2022
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@jcfranco jcfranco mentioned this issue Jul 10, 2023
Closed
@geospatialem geospatialem mentioned this issue Jul 25, 2023
Closed
6 tasks
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Dec 18, 2023
@jcfranco jcfranco mentioned this issue Dec 18, 2023
Open
9 tasks
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Jan 10, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Elijbet Elijbet

Labels
1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
3 participants
@alisonailea @geospatialem @Elijbet