Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openCloseComponent: apply the interface to additional components to have consistent eventing for opening/closing #5056

Closed
Elijbet opened this issue Jul 29, 2022 · 4 comments
Closed

openCloseComponent: apply the interface to additional components to have consistent eventing for opening/closing #5056

Elijbet opened this issue Jul 29, 2022 · 4 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Milestone
2024-09-24 - Sep ...

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jul 29, 2022 •
edited

Description

Implement openCloseComponent Interface by using the new onToggleOpenCloseComponent pattern. This new pattern is intended to simplify the overall eventing logic.

Acceptance Criteria

Components implement the interface to consistently handle emitting open, beforeOpen, close, beforeClose events.

Relevant Info

Related to PR #4975 and original Issue: #4689

Which Component

  • block
  • input time picker
  • notice

Example Use Case

No response
@Elijbet Elijbet added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 29, 2022
@Elijbet Elijbet self-assigned this Jul 29, 2022
@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 29, 2022
@benelan benelan added this to the Sprint 07/25 - 08/05 milestone Jul 29, 2022
@Elijbet Elijbet mentioned this issue Aug 3, 2022
Open
@jcfranco jcfranco mentioned this issue Aug 23, 2022
Closed
@jcfranco
Copy link
Member

Let's use this issue to drive implementing the pattern/util. Can you assimilate #6017 here and close it afterwards?

@geospatialem geospatialem mentioned this issue Jul 25, 2023
Closed
6 tasks
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 25, 2023
@Elijbet
Copy link
Contributor Author

Elijbet commented Aug 8, 2023 •
edited

Some components (tooltip, popover, input-date-picker) have also been covered in the following issue: #7358

@Elijbet Elijbet mentioned this issue Aug 9, 2023
Merged
3 tasks
Elijbet added a commit that referenced this issue Sep 23, 2023
@Elijbet
feat(block, input-time-picker, notice): adds open, close, `before…
04ce758 
…Open`, and `beforeClose` events for consistent event handling (#7494)

**Related Issue:** #5056

## Summary
Implement `openCloseComponent` Interface by using the new
`onToggleOpenCloseComponent` pattern. This new pattern is intended to
simplify the overall eventing logic.

Components implement the interface to consistently handle emitting
`open, beforeOpen, close, beforeClose events`.

- [x] block
- [x] input-time-picker
- [x] notice
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 10, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 21, 2023
@geospatialem
Copy link
Member

Verified on the main branch for the following components:

  • alert
  • block
  • combobox
  • dropdown
  • input-date-picker
  • input-time-picker
  • modal
  • notice
  • popover
  • sheet
  • tooltip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
2024-09-24 - Sep Main release
Development

No branches or pull requests
5 participants
@jcfranco @alisonailea @geospatialem @benelan @Elijbet