Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tile-select] Can't make selection by clicking tile with dist-custom-elements #6185

Closed
mpayson opened this issue Dec 28, 2022 · 3 comments
Closed

[tile-select] Can't make selection by clicking tile with dist-custom-elements #6185

mpayson opened this issue Dec 28, 2022 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 March Priori...

Comments

@mpayson
Copy link

mpayson commented Dec 28, 2022

Actual Behavior

It looks like when using dist-custom-elements, users can't click a tile to make a selection for tile select components, they have to click the radio button circle. This differs from the dist behavior, where the user can click the entire tile to make a selection.

Expected Behavior

The user can click the tile to make a selection like with the dist output.

Reproduction Sample

https://github.com/mpayson/calcite-components-examples/tree/tile-select-issue

Reproduction Steps

  1. Clone the repository and checkout the tile-select-issue branch
  2. cd react && npm install && npm start
  3. Click a tile, see it does not make a selection
  4. Go to this codepen: https://codepen.io/mpayson/pen/yLqezWB
  5. Click a tile, see it does make a selection

Reproduction Version

beta.99

Relevant Info

No response

Regression?

No response

Impact

No response

Esri team

ArcGIS Online
@mpayson mpayson added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 28, 2022
@github-actions github-actions bot added the ArcGIS Online Issues logged by ArcGIS Online team members. label Dec 28, 2022
@geospatialem geospatialem added the research Issues that require additional research in order to resolve or make decision. label Feb 28, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 28, 2023
@geospatialem
Copy link
Member

Research will be conducted in March to determine next steps.

@brittneytewks brittneytewks added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Mar 21, 2023
@jcfranco jcfranco assigned jcfranco and unassigned benelan Mar 27, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed research Issues that require additional research in order to resolve or make decision. 1 - assigned Issues that are assigned to a sprint and a team member. labels Mar 27, 2023
@jcfranco jcfranco mentioned this issue Mar 27, 2023
Merged
jcfranco added a commit that referenced this issue Mar 27, 2023
@jcfranco
fix(tile-select): fix click not firing in custom-elements build (#6665)
71aa826 
**Related Issue:** #6185 

## Summary

Renames event handlers to prevent click listener not firing when the
tile-select area was clicked in the `dist-custom-elements` output
target. This seems like a Stencil bug caused when an event handler is
identical to its listened event name.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Mar 27, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Mar 27, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 28, 2023
@geospatialem
Copy link
Member

Verified in 1.2.0-next.0

verify-select

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 March Priorities - No breaking c...
Development

No branches or pull requests
6 participants
@jcfranco @alisonailea @geospatialem @mpayson @benelan @brittneytewks