Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Unexpected behavior when programmatically updating props #6375

Closed
macandcheese opened this issue Jan 30, 2023 · 2 comments
Closed

[Slider] Unexpected behavior when programmatically updating props #6375

macandcheese opened this issue Jan 30, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-slider Issues that pertain to the calcite-slider component Calcite (design) Issues logged by Calcite designers. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Milestone
1.6.0 - Low risk ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jan 30, 2023 •
edited
Loading

Actual Behavior

When programmatically updating slider, the changes don't accurately reflect in the component:

Screen.Recording.2023-01-29.at.8.42.00.PM.mov

Expected Behavior

I'd expect the Slider to accurately reflect the updated property values

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/gOjjjZO?editors=1000

Reproduction Steps

  1. Open Codepen
  2. Use the buttons to adjust the Slider component
  3. See component not reflect changes correctly.

Reproduction Version

1.0.3

Relevant Info

No response

Regression?

Could not find a working previous version

Impact

No response

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 30, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Jan 30, 2023
@brittneytewks brittneytewks added p - low Issue is non core or affecting less that 10% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. c-slider Issues that pertain to the calcite-slider component labels Apr 11, 2023
@brittneytewks brittneytewks added this to the 2023 July Priorities milestone Apr 11, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Apr 11, 2023
@jcfranco jcfranco self-assigned this Aug 3, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 3, 2023
@jcfranco jcfranco mentioned this issue Aug 3, 2023
Merged
jcfranco added a commit that referenced this issue Aug 15, 2023
@jcfranco
fix(slider): rerender ticks when prop is modified (#7439)
20058a9 
**Related Issue:** #6375

## Summary

This adds a watcher for `ticks` to update slider ticks.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 15, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Aug 15, 2023
@geospatialem geospatialem removed this from the 2023 August Priorities milestone Aug 15, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 15, 2023
@geospatialem
Copy link
Member

Verified on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-slider Issues that pertain to the calcite-slider component Calcite (design) Issues logged by Calcite designers. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
1.6.0 - Low risk issues only
Development

No branches or pull requests
5 participants
@jcfranco @alisonailea @macandcheese @geospatialem @brittneytewks