Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Combobox] While focusing on Chip's close button, spacebar opens Combobox menu #6777

Closed
macandcheese opened this issue Apr 13, 2023 · 5 comments
Closed

[Combobox] While focusing on Chip's close button, spacebar opens Combobox menu #6777

macandcheese opened this issue Apr 13, 2023 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-combobox Issues that pertain to the calcite-combobox and related components Calcite (design) Issues logged by Calcite designers. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-03-26 - Mar ...

Comments

@macandcheese
Copy link
Contributor

Actual Behavior

When using Combobox, and focus is on a select item's representative chip's close button - using Space key will open the Combobox item dropdown.

Expected Behavior

I'd expect the Space key to close the chip (match Enter), as the Chip component in isolation does.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/combobox/

Reproduction Steps

  1. Open sample on dev site
  2. Select some items from Combobox
  3. Focus chip close button with keyboard
  4. Use "Space" key
  5. Combobox will open and chip will not close

Reproduction Version

1.2

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 13, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (design) Issues logged by Calcite designers. labels Apr 13, 2023
@macandcheese macandcheese added the c-combobox Issues that pertain to the calcite-combobox and related components label Apr 13, 2023
@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Jul 19, 2023
This was referenced Jul 19, 2023
Closed
Closed
@geospatialem geospatialem added this to the 2023 December Priorities milestone Jul 19, 2023
@geospatialem
Copy link
Member

Related and could be approached together with #6750 + #6776

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Nov 14, 2023
@brittneytewks brittneytewks added the estimate - 3 A day or two of work, likely requires updates to tests. label Jan 29, 2024
@Elijbet Elijbet self-assigned this Mar 8, 2024
@Elijbet Elijbet added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Mar 8, 2024
@Elijbet Elijbet mentioned this issue Mar 8, 2024
Merged
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Mar 21, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem
Copy link
Member

It looks like the combobox still opens when using the spacebar on both Windows and Mac across browsers with https://codepen.io/geospatialem/pen/yLrMZWW.

@Elijbet reassigning back to ya to take another peek to investigate what might be happening. 👀

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 21, 2024
@Elijbet Elijbet mentioned this issue Mar 22, 2024
Merged
Elijbet added a commit that referenced this issue Mar 25, 2024
@Elijbet
fix(combobox): prevent spacebar from opening the menu when focused on…
1a20d0e 
… chip's close button (#8990)

**Related Issue:** #6777

## Summary

Prevent spacebar from opening the menu when focused on chip's `close`
button.

Fixes a regression introduced in
#8909.
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Mar 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 25, 2024
@geospatialem
Copy link
Member

Verified in 2.7.0-next.15 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-combobox Issues that pertain to the calcite-combobox and related components Calcite (design) Issues logged by Calcite designers. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-03-26 - Mar Release
Development

No branches or pull requests
5 participants
@macandcheese @geospatialem @Elijbet @DitwanP @brittneytewks