Create additional packages/workspaces within the monorepo

[benelan]

Summary

The initial monorepo PR is installed! Once we ensure everything is running smoothly, we can start splitting out some of the code in packages/calcite-components into separate workspaces. Turbo has an example project where they have separate workspaces for eslint, tsconfig, and storybook. We could potentially split the demo pages into its own workspace as well.

In addition to creating workspaces from existing code in the monorepo, we can start moving in packages from other repos. Here is a list copied from #6532:

• @esri/calcite-components-react
• @esri/eslint-plugin-calcite-components
• @esri/calcite-design-tokens
• @esri/calcite-components-angular
• @esri/calcite-ui-icons [Tooling] Add @esri/calcite-ui-icons to the monorepo packages #9255
• framework examples [Tooling] Add framework examples to the monorepo packages #9256
• configuration [Tooling] Add configuration including sharing across the monorepo #9257
  • shared eslint configuration (see turbo's example linked above)
  • tsconfigs (see turbo's example linked above)
  • storybook (see turbo's example linked above)
• component utils (future)
• test utils (future)
• demos (future)

Desired Outcome

Adding more Calcite packages to the repo and splitting existing functionality into encapsulated workspaces will improve maintainability and discoverability.

Resources

No response

[driskull]

@esri/calcite-ui-icons (potentially)

Seems like this would be good to be in the monorepo right? Anything calcite should be in this repo ideally.

[benelan]

Yeah I think Franco put the "potentially" there before he talked with @SkyeSeitz and the other maintainers. I just copied it from his list in the issue I linked. But last I heard we are on track to move the icons to the monorepo.

[SkyeSeitz]

Thanks, @benelan. Can you remind me of the impact so so I can confirm with the Graphic Illustration team on any updates to their workflow - if any? A url change? Any impacts on maintaining this site?

[benelan]

Yeah the code would be moved to this repo so they would need to get set up here with permissions etc. The github pages site would need to be moved as well

Edit: On the plus side it would mean they don't have to deal with the deployment side of things anymore

[alisonailea]

I'd like to propose we create a /configs folder at root for all shared configs (typescript, jest, eslint, etc.) and a /tools folder for shared tooling (tokens-transformer) these would need to be added as additional turbo workspaces to be usable by /packages

[driskull]

I'd like to propose we create a /configs folder at root for all shared configs (typescript, jest, eslint, etc.) and a /tools folder for shared tooling (tokens-transformer) these would need to be added as additional turbo workspaces to be usable by /packages

I like this idea but I'm not sure these kind of configurations fall into the design system. do they?

[benelan]

It would just be the shared configs for the design system. Here is an example of a shared eslint config from turbo:
https://github.com/vercel/turbo/tree/main/examples/design-system/packages/eslint-config-acme

which can be installed and extended in other packages within the monorepo:
https://github.com/vercel/turbo/blob/main/examples/design-system/packages/acme-core/package.json#L23
https://github.com/vercel/turbo/blob/main/examples/design-system/packages/acme-core/.eslintrc.js#L3

[benelan]

I'd like to propose we create a /configs folder at root for all shared configs (typescript, jest, eslint, etc.)

I started on this but ran into issues with the typescript parser. Here are some resources for when @alisonailea or I pick it back up:

• https://typescript-eslint.io/linting/typed-linting/monorepos
• https://turbo.build/repo/docs/handbook/linting/typescript
• https://turbo.build/repo/docs/handbook/linting
• I ran into this bug but it shouldn't be an issue once we figure out how to setup the typescript parser correctly: @stencil/async-methods is not working properly stencil-community/stencil-eslint#15
• Other than the parser it should be done, here is what I have so far: 2445bd5