Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color picker value does not update when alphaChannel is changed from false to true #7205

Closed
driskull opened this issue Jun 20, 2023 · 2 comments
Closed

Color picker value does not update when alphaChannel is changed from false to true #7205

driskull opened this issue Jun 20, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 August Prior...

Comments

@driskull
Copy link
Member

Actual Behavior

If you start with a basic color picker and then set the alphaValue to true after initialization, the value does not update with an alpha value.

Even if you type a new hex color in the textbox or change the alpha text box number from 100 to 50, the value of the component does not update.

Expected Behavior

The alphaChannel will update the value of the component.

I would expect any changes to alphaChannel as well as typing into any of the textboxes to update the value of the component.

Reproduction Sample

https://codepen.io/driskull/pen/gOQwYPM

Reproduction Steps

  1. Open codepen
  2. See default value
  3. Type in a new alpha value
  4. Verify that value has not changed. (it should);

Reproduction Version

Latest

Relevant Info

N/A

Regression?

No

Priority impact

p4 - not time sensitive

Impact

No response

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 20, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Jun 20, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Jun 21, 2023
@geospatialem geospatialem added this to the 2023 July Priorities milestone Jun 21, 2023
@geospatialem geospatialem added the estimate - 2 Small fix or update, may require updates to tests. label Jul 3, 2023
@jcfranco jcfranco changed the title Colorpicker value does not update when alphaChannel is changed from false to true Color picker value does not update when alphaChannel is changed from false to true Aug 22, 2023
@jcfranco jcfranco self-assigned this Aug 22, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Aug 22, 2023
@jcfranco jcfranco mentioned this issue Aug 22, 2023
Merged
jcfranco added a commit that referenced this issue Aug 22, 2023
@jcfranco
fix(color-picker): update value when alphaChannel is toggled (#7563)
1f753dd 
**Related Issue:** #7205 

## Summary

This updates the color picker to update its state properly when
`alphaChannel` is toggled.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 22, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Aug 22, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 27, 2023
@geospatialem
Copy link
Member

Verified in 1.7.0-next.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 August Priorities
Development

No branches or pull requests
3 participants
@jcfranco @driskull @geospatialem