Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable read-only prop for Navigation Logo #7495

Closed
3 tasks done
apfister opened this issue Aug 9, 2023 · 2 comments
Closed
3 tasks done

Enable read-only prop for Navigation Logo #7495

apfister opened this issue Aug 9, 2023 · 2 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@apfister
Copy link

apfister commented Aug 9, 2023

Check existing issues

Description

I'd like to have the Navigation Logo component provide a readOnly property. When enabled, the component is used only for displaying the Title and/or subtitle and invites no user interaction.

Acceptance Criteria

having a prop on the component may be easiest?

Relevant Info

No response

Which Component

Navigation Logo https://developers.arcgis.com/calcite-design-system/components/navigation-logo/

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

N/A

@apfister apfister added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 9, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 9, 2023
@macandcheese
Copy link
Contributor

In Input, readOnly results in a focusable component, but right now the content in a Navigation Logo can't be reached via focus if href is not populated.

The result of this issue: #7078 will be to always have the element focusable, currently it has a hover effect but cannot be focused when href not populated.

As a result, all Navigation Logo instances with href or without will be focusable. But I think it still needs to be focusable to support AT. cc @geospatialem to confirm or ... disconfirm the above. If its the latter, we could look at a nonInteractive property or something similar.

@geospatialem
Copy link
Member

As a result, all Navigation Logo instances with href or without will be focusable. But I think it still needs to be focusable to support AT.

Concur with @macandcheese's summary above, the component should always be focusable for AT support to provide context to more users.

However, we have plans to address conditions on navigation-logo depending on the presence of href as Adam mentioned above via #7078.

Closing the above as its not a pattern Calcite supports at this time for a11y support and web patterns with navigation.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants