Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation Logo] Refactor component to conditionally render anchor or div #7078

Open
macandcheese opened this issue Jun 1, 2023 · 1 comment
Open

[Navigation Logo] Refactor component to conditionally render anchor or div #7078

macandcheese opened this issue Jun 1, 2023 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jun 1, 2023 •
edited

Description

Follow up from #6606

Acceptance Criteria

The Navigation Logo component should conditionally render an anchor or div element depending on the presence of 'href' - similar to Button.

Relevant Info

No response

Which Component

Navigation Logo

Example Use Case

This will enable better keyboard support and focus handling. Currently you cannot easily set up the component to be focusable and not have a navigation href.

Priority impact

p3 - want for upcoming milestone

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 1, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. p3 - want for upcoming milestone labels Jun 1, 2023
@macandcheese macandcheese mentioned this issue Jun 1, 2023
Closed
6 tasks
@macandcheese macandcheese added the estimate - 3 A day or two of work, likely requires updates to tests. label Oct 25, 2023
@macandcheese macandcheese self-assigned this Oct 25, 2023
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 25, 2023
This was referenced Oct 25, 2023
Merged
Closed
@macandcheese macandcheese changed the title [Navigation Logo] Refactor component to conditionally render anchor or button [Navigation Logo] Refactor component to conditionally render anchor or div Oct 26, 2023
@macandcheese macandcheese added 0 - new New issues that need assignment. and removed 2 - in development Issues that are actively being worked on. labels Apr 8, 2024
@macandcheese macandcheese removed their assignment Apr 8, 2024
@macandcheese macandcheese mentioned this issue Apr 17, 2024
Open
6 tasks
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 30, 2024
@geospatialem
Copy link
Member

Should be tackled in the same milestone as #9139.

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macandcheese @geospatialem