Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input Time Zone: can't retrieve appropriate offset value or message after deselecting dropdown option #7530

Closed
2 of 3 tasks
ian13262 opened this issue Aug 15, 2023 · 3 comments
Closed
2 of 3 tasks

Input Time Zone: can't retrieve appropriate offset value or message after deselecting dropdown option #7530

ian13262 opened this issue Aug 15, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
1.8.0 Maintenance...

Comments

@ian13262
Copy link

ian13262 commented Aug 15, 2023 •
edited

Check existing issues

Actual Behavior

Deselecting the currently selected time zone from the calcite-input-time-zone dropdown causes an offsetValue error in Dev Tools Console and an inability to retrieve the offset value.

Expected Behavior

When no time zone is selected, offsetValue should have some appropriate value or string indicating as such so that we can appropriately handle setting time zones.

Reproduction Sample

https://codepen.io/iyouth66/pen/PoXYZJG

Reproduction Steps

1.) Open Codepen > Open the calcite-input-time-zone dropdown
2.) Deselect the currently selected time zone
3.) Open Dev Tools > Console
4.) An offsetValue error is displayed

Reproduction Version

1.5

Relevant Info

cc @jcfranco

Regression?

N/A

Priority impact

p3 - want for upcoming milestone

Impact

We need the offsetValue when setting time zones in Map Viewer (or eventually the corresponding representative IANA string - see #7430). When all options are deselected, this needs to be indicated somehow as well.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Online
@ian13262 ian13262 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 15, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Online Issues logged by ArcGIS Online team members. labels Aug 15, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. estimate - 3 A day or two of work, likely requires updates to tests. labels Aug 21, 2023
@jcfranco
Copy link
Member

Implementer's note: this should now be feasible via combobox's new single-persist mode.

@jcfranco jcfranco self-assigned this Aug 26, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Sep 1, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 1, 2023
@jcfranco jcfranco mentioned this issue Sep 1, 2023
Merged
jcfranco added a commit that referenced this issue Sep 5, 2023
@jcfranco
fix(input-time-zone): prevent items from being deselected (#7661)
c2dd436 
**Related Issue:** #7530

## Summary

Leverages `combobox`'s new `single-persist` mode to avoid an error
caused by deselecting an item.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Sep 5, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 7, 2023
@geospatialem
Copy link
Member

Verified in 1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
1.8.0 Maintenance Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @ian13262