Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List item: slotted actions obstruct portion of list outline with active #7538

Closed
2 of 3 tasks
COV-GIS opened this issue Aug 16, 2023 · 22 comments
Closed
2 of 3 tasks

List item: slotted actions obstruct portion of list outline with active #7538

COV-GIS opened this issue Aug 16, 2023 · 22 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-list Issues that pertain to the calcite-list component calcite-components Issues specific to the @esri/calcite-components package. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that. spike Issues that cannot be estimated well enough until the team has done further research
Milestone
2024-06-25 - Jun ...

Comments

@COV-GIS
Copy link

COV-GIS commented Aug 16, 2023 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

1.4.3 and higher:

image

Expected Behavior

1.4.2:

image

Reproduction Sample

https://codepen.io/geospatialem/pen/VwOXGgr
https://codepen.io/COV-GIS/pen/wvRwmPV?editors=100

Reproduction Steps

Switch between 1.4.2 and 1.4.3 in sample.

Reproduction Version

1.6.0

Relevant Info

No response

Regression?

1.4.2

Priority impact

impact - p3 - not time sensitive

Impact

Does not affect usability or workflows. Just aesthetics.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

N/A
@COV-GIS COV-GIS added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 16, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 16, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. regression Issues that are caused by changes in a release, but were working before that. p - medium Issue is non core or affecting less that 60% of people using the library and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 16, 2023
@jcfranco jcfranco assigned macandcheese and unassigned driskull Aug 16, 2023
@jcfranco
Copy link
Member

As a workaround, action's appearance prop can be set to transparent (via @driskull 🏆). cc @macandcheese

@jcfranco jcfranco added the has workaround Issues have a workaround available in the meantime. label Aug 18, 2023
@geospatialem geospatialem added the spike Issues that cannot be estimated well enough until the team has done further research label Aug 30, 2023
@geospatialem
Copy link
Member

Additional information needs to determine a potential fix that doesn't impact the original fix creating the regression.

@geospatialem geospatialem added low risk Issues with low risk for consideration in low risk milestones spike Issues that cannot be estimated well enough until the team has done further research and removed spike Issues that cannot be estimated well enough until the team has done further research labels Oct 2, 2023
@geospatialem geospatialem added 0 - new New issues that need assignment. and removed spike Issues that cannot be estimated well enough until the team has done further research 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 23, 2023
josercarcamo added a commit that referenced this issue Jun 20, 2024
@josercarcamo
fix(list-item): Improve focus outline appearance (#9653)
b3d2cb2 
**Related Issue:** #7538 

## Summary
Make list item highlight display correctly over action items.
@josercarcamo josercarcamo added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@macandcheese
Copy link
Contributor

For verification - I think the installed PR still has some issues to resolve - it is causing overlaps as the focus is outset and ends up not being visible in Panel, etc:

Merged PR:
Screenshot 2024-06-21 at 10 50 27 AM

Screenshot 2024-06-21 at 10 33 25 AM

Expected (#9534):
Screenshot 2024-06-21 at 10 34 18 AM

Screenshot 2024-06-21 at 10 34 03 AM

@DitwanP
Copy link
Contributor

DitwanP commented Jun 21, 2024

Confirming what Adam said above.image

Reassigning to remedy this 👆

@DitwanP DitwanP added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 21, 2024
@DitwanP DitwanP assigned josercarcamo and unassigned geospatialem and DitwanP Jun 21, 2024
@josercarcamo josercarcamo mentioned this issue Jun 24, 2024
Merged
josercarcamo added a commit that referenced this issue Jun 24, 2024
@josercarcamo
fix(list-item): improve list item outline (#9675)
b8c2fff 
**Related Issue:** #7538 

## Summary
Improves outline around list item.
@josercarcamo josercarcamo added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned josercarcamo Jun 24, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jun 24, 2024

This looks good to me locally on dev

PREVIOUSLY:
image
image

CURRENTLY:
imageimage

@macandcheese thoughts?

@DitwanP
Copy link
Contributor

DitwanP commented Jun 24, 2024

🍡 Verified

@DitwanP DitwanP closed this as completed Jun 24, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-list Issues that pertain to the calcite-list component calcite-components Issues specific to the @esri/calcite-components package. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that. spike Issues that cannot be estimated well enough until the team has done further research
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
9 participants
@jcfranco @driskull @alisonailea @macandcheese @geospatialem @COV-GIS @DitwanP @brittneytewks @josercarcamo