Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calciteListChange event emitted on manual item disable/enable #7627

Closed
1 of 3 tasks
nid13240 opened this issue Aug 30, 2023 · 2 comments
Closed
1 of 3 tasks

calciteListChange event emitted on manual item disable/enable #7627

nid13240 opened this issue Aug 30, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2023 August Prior...

Comments

@nid13240
Copy link

Check existing issues

Actual Behavior

When I manually enable/disable list items (by setting the disabled property), I notice that the calciteListChange event now gets emitted as of 1.5.0. For my use case, I manually set this property in the calciteListChange event handler which creates an infinite loop.

Expected Behavior

I do not expect this event to be emitted when I manually change the disabled property on a list item.

Reproduction Sample

https://codepen.io/nid13240/pen/JjwXaoj?editors=1011

Reproduction Steps

  1. open the codepen above (currently set to calcite version 1.4.3)
  2. select the first list item and observe the list items enable/disable as expected
  3. change the version to 1.5.0 or later
  4. select the first list item and observe the items enabling/disabling infinitely

Reproduction Version

1.5.0

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Map Viewer
@nid13240 nid13240 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 30, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. labels Aug 30, 2023
@driskull driskull mentioned this issue Aug 30, 2023
Merged
@driskull driskull added the regression Issues that are caused by changes in a release, but were working before that. label Aug 30, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Aug 31, 2023
@jcfranco jcfranco assigned jcfranco and driskull and unassigned jcfranco Aug 31, 2023
@jcfranco jcfranco added this to the 2023 August Priorities milestone Aug 31, 2023
driskull added a commit that referenced this issue Aug 31, 2023
@driskull
fix(list): Stop emitting calciteListChange when a list-item is disabl…
7008463 
…ed or closed. (#7624)

**Related Issue:** #7627

## Summary

- calciteListChange shouldn't be emitting when an item is disabled or
closed.
@driskull driskull added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Aug 31, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Aug 31, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed 2 - in development Issues that are actively being worked on. needs triage Planning workflow - pending design/dev review. labels Aug 31, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 31, 2023
@geospatialem
Copy link
Member

Verified with 1.7.0-next.17 with the calciteListChange event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2023 August Priorities
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @nid13240