Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Bar, Action Group and Action - Ensure implicit list markup is avoided - (2036569765) #7776

Closed
dqateam opened this issue Sep 19, 2023 · 3 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. a11y Issues related to Accessibility fixes or improvements. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that cannot be estimated well enough until the team has done further research

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure implicit list markup is avoided

WCAG Reference:

Severity:

6

Media Type:

Lists


Areas for Remediation:

  • Title: Action Bar, Action Group and Action - Ensure implicit list markup is avoided - (2036569765)

  • Module: Action Bar, Action Group and Action
    Issue
    There is content that appears as a list but does not use list markup. Examples include:

  • Information

  • Feedback

  • Layers

  • Basemaps

  • Collapse

User Impact
Screen reader users will have difficulty understanding that this content is a list.

Code Reference

<calcite-action-bar layout="vertical" calcite-hydrated="" expanded="">
 <calcite-action-group layout="vertical" calcite-hydrated="" expanded="">
   <calcite-action text="Information" icon="information" label="Information action, for display purposes only" appearance="solid" scale="m" calcite-hydrated="" text-enabled=""></calcite-action>
   <calcite-action text="Feedback" icon="mega-phone" label="Feedback action, for display purposes only" appearance="solid" scale="m" calcite-hydrated="" text-enabled=""></calcite-action>
 </calcite-action-group>
 <calcite-action-group layout="vertical" calcite-hydrated="" expanded="">
   <calcite-action text="Layers" icon="layers" label="Layers action, for display purposes only" appearance="solid" scale="m" calcite-hydrated="" text-enabled=""></calcite-action>
 </calcite-action-group>
 (...)
</calcite-action-bar>

Suggestion
Ensure implicit list markup is avoided. Lists must use <ul>, <ol>, <li>, <dl>, <dt>, and <dd> elements as appropriate.

Compliant Code Example

<ul layout="vertical" calcite-hydrated="" expanded="">
 <li>
   <calcite-action text="Information" icon="information" label="Information action, for display purposes only" appearance="solid" scale="m" calcite-hydrated="" text-enabled=""></calcite-action>
 </li>
 <li>
   <calcite-action text="Feedback" icon="mega-phone" label="Feedback action, for display purposes only" appearance="solid" scale="m" calcite-hydrated="" text-enabled=""></calcite-action>
 </li>
 <li>
   <calcite-action text="Layers" icon="layers" label="Layers action, for display purposes only" appearance="solid" scale="m" calcite-hydrated="" text-enabled=""></calcite-action>
 </li>
 (...)
</ul>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@geospatialem geospatialem added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that cannot be estimated well enough until the team has done further research labels Sep 19, 2023
@geospatialem geospatialem self-assigned this Sep 19, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@geospatialem
Copy link
Member

Next steps to conduct a research spike to determine a potential solution and estimate for implementation in late 2023/early 2024.

@macandcheese
Copy link
Contributor

Propose closing as a result of discussion in #7052. These really should behave more as toolbars.

@geospatialem
Copy link
Member

Closing per #7776 (comment) and in favor of the effort of #7052.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. a11y Issues related to Accessibility fixes or improvements. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that cannot be estimated well enough until the team has done further research
Projects
None yet
Development

No branches or pull requests

3 participants