Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination - Ensure implicit list markup is avoided - (2036570528) #7804

Closed
dqateam opened this issue Sep 19, 2023 · 3 comments
Closed

Pagination - Ensure implicit list markup is avoided - (2036570528) #7804

dqateam opened this issue Sep 19, 2023 · 3 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure implicit list markup is avoided

image

WCAG Reference:

Severity:

6

Media Type:

Lists


Areas for Remediation:

  • Title: Pagination - Ensure implicit list markup is avoided - (2036570528)
  • Module: Pagination
    Issue
    There is content that appears as a list but does not use list markup. Examples include:
  • "Pagination component"

User Impact
Screen reader users will have difficulty understanding that this content is a list.

Code Reference

<button aria-label="Previous" class="previous"><calcite-icon aria-hidden="true" icon="chevronLeft" flip-rtl="" scale="s" calcite-hydrated=""></calcite-icon></button>
<button class="page">1</button>
(...)
<button class="page">1,500</button>
<button aria-label="Next" class="next"><calcite-icon aria-hidden="true" icon="chevronRight" flip-rtl="" scale="s" calcite-hydrated=""></calcite-icon></button>

Suggestion
Ensure implicit list markup is avoided. Lists must use <ul>, <ol>, <li>, <dl>, <dt>, and <dd> elements as appropriate.

Compliant Code Example

<ul>
<li><button aria-label="Previous" class="previous"><calcite-icon aria-hidden="true" icon="chevronLeft" flip-rtl="" scale="s" calcite-hydrated=""></calcite-icon></button>
<button class="page">1</button></li>
(...)
<li><button class="page">1,500</button></li>
<li><button aria-label="Next" class="next"><calcite-icon aria-hidden="true" icon="chevronRight" flip-rtl="" scale="s" calcite-hydrated=""></calcite-icon></button>
</li>
<ul>



Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@driskull
Copy link
Member

This one seems valid, internal shadow HTML should be more semantic.

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 8, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 10, 2024
@driskull driskull self-assigned this May 31, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 31, 2024
driskull added a commit that referenced this issue May 31, 2024
**Related Issue:** #7804

## Summary

- render a list and list items internally
- add test to ensure future compliance
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 31, 2024
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull May 31, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jun 3, 2024

🍡 Verified on 2.9.1-next.0
image

@DitwanP DitwanP closed this as completed Jun 3, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

4 participants