Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree and tree item - unable to navigate to after making a selection by the keyboard #7898

Closed
2 of 4 tasks
yohannlouis opened this issue Sep 28, 2023 · 4 comments
Closed
2 of 4 tasks

Tree and tree item - unable to navigate to after making a selection by the keyboard #7898

yohannlouis opened this issue Sep 28, 2023 · 4 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2023 September Pr...

Comments

@yohannlouis
Copy link

yohannlouis commented Sep 28, 2023 •
edited by geospatialem
Loading

Check existing issues

Summary

When using the keyboard allow the user to navigate to the tree after selecting a tree item.

Actual Behavior

When using the keyboard to navigate and select the tree item, it collapses the tree and it can be no longer navigated to.

2023-09-28_09-45-53.mp4

Expected Behavior

When using the keyboard allow the user to navigate to the tree after selecting a tree item.

Reproduction Sample

documentation sample https://developers.arcgis.com/calcite-design-system/components/tree/

Reproduction Steps

  1. Open the calcite-design-system > components > tree sample https://developers.arcgis.com/calcite-design-system/components/tree/
  2. Using the keyboard, navigate to a tree item and make a selection by hitting enter.
  3. Notice the tree collapses
  4. Try navigating to the tree or tree item. Notice it can no longer be navigated to

Reproduction Version

1.8.0

Working W3C Example/Tutorial

No response

Relevant Info

No response

Regression?

Last working version 1.3.0

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@yohannlouis yohannlouis added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Sep 28, 2023
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Sep 28, 2023
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Sep 28, 2023
@jcfranco jcfranco self-assigned this Sep 29, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. spike Issues that cannot be estimated well enough until the team has done further research and removed 0 - new New issues that need assignment. labels Sep 29, 2023
@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 29, 2023
@jcfranco
Copy link
Member

jcfranco commented Sep 29, 2023 •
edited
Loading

[Spike] Dug into this a bit and I believe we should be able to tackle this one for the current release. Picking it up.

@jcfranco jcfranco removed the spike Issues that cannot be estimated well enough until the team has done further research label Sep 29, 2023
@jcfranco jcfranco mentioned this issue Sep 29, 2023
Merged
jcfranco added a commit that referenced this issue Sep 29, 2023
@jcfranco
fix(tree): fix tree keyboard selection issue (#7908)
53d6c12 
**Related Issue:** #7898 

## Summary

Fixes issue where selecting a child with the keyboard would collapse its
parent and lose focus and mess up keyboard navigation.
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. labels Sep 29, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@yohannlouis
Copy link
Author

yohannlouis commented Oct 2, 2023 •
edited
Loading

@jcfranco where can I verify these changes? Unable to see them in Devext or the sample in https://developers.arcgis.com/calcite-design-system/components/tree/

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 2, 2023
@geospatialem
Copy link
Member

@jcfranco where can I verify these changes? Unable to see them in Devext or the sample in https://developers.arcgis.com/calcite-design-system/components/tree/

@yohannlouis Great question, put together a Codepen for testing, which used our latest release of 1.9.0-next.16 as of 10/2/2023 at 12:00pm PDT.

verify-7898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @yohannlouis