Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button doubly faded when in both disabled and loading states #7950

Closed
2 of 4 tasks
nwhittaker opened this issue Oct 5, 2023 · 3 comments
Closed
2 of 4 tasks

Button doubly faded when in both disabled and loading states #7950

nwhittaker opened this issue Oct 5, 2023 · 3 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 2 Small fix or update, may require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 October Prio...

Comments

@nwhittaker
Copy link
Contributor

nwhittaker commented Oct 5, 2023 •
edited

Check existing issues

Actual Behavior

Enabling both disabled and loading attributes on a <calcite-button> element causes the button to appear twice as faded as it would if only one of those attributes was applied.

Expected Behavior

Button has the same amount of fading regardless if one or both attributes are enabled.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/button/

Reproduction Steps

  1. Navigate to the documentation sample for the Button component
  2. Enable the loading attribute and see button becomes faded
  3. Enable the disabled attribute and see button becomes more faded
  4. Disable the loading attribute and see the button becomes less faded

Reproduction Version

1.9.0

Relevant Info

Somewhat related to #7590 in that a workaround for that issue is to supply both disabled and loading attributes.

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

Inconsistent UI where some buttons can look more faded than others despite being semantically the same in terms of their disabled state.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 5, 2023
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Oct 5, 2023
@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. good first issue Issues that can be worked on by contributors new to calcite-components. low risk Issues with low risk for consideration in low risk milestones and removed needs triage Planning workflow - pending design/dev review. labels Oct 14, 2023
@jcfranco
Copy link
Member

This would take care of #6453.

@jcfranco jcfranco self-assigned this Oct 14, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 14, 2023
@jcfranco jcfranco removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Oct 14, 2023
@jcfranco jcfranco mentioned this issue Oct 14, 2023
Merged
@jcfranco jcfranco added design Issues that need design consultation prior to development. figma changes Issues that require additions or updates to the Figma UI Kit labels Oct 14, 2023
jcfranco added a commit that referenced this issue Oct 20, 2023
@jcfranco
fix(button, fab, inline-editable, split-button): prevent redundant op…
3a1d3fd 
…acity when button is both loading and disabled (#8015)

**Related Issue:** #7950 

## Summary

🚫👻👻
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 20, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned brittneytewks and unassigned jcfranco Oct 20, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 25, 2023
@geospatialem
Copy link
Member

Verified in 1.10.0-next.7 with https://codepen.io/geospatialem/pen/zYeGaWv

image

@geospatialem geospatialem mentioned this issue Oct 25, 2023
Closed
@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 2 Small fix or update, may require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

No branches or pull requests
6 participants
@jcfranco @nwhittaker @geospatialem @SkyeSeitz @ashetland @brittneytewks