Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for overriding scales for CalciteIcons #8006

Closed
1 of 5 tasks
meescool opened this issue Oct 13, 2023 · 5 comments
Closed
1 of 5 tasks

Allow for overriding scales for CalciteIcons #8006

meescool opened this issue Oct 13, 2023 · 5 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS StoryMaps Issues logged by ArcGIS StoryMaps team members enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone low risk Issues with low risk for consideration in low risk milestones p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 October Prio...

Comments

@meescool
Copy link

meescool commented Oct 13, 2023 •
edited

Check existing issues

Description

To be able to override CalciteIcon scales.

Acceptance Criteria

To be able to override the CalciteIcon scales. This way we can account for when the base size for rem differs from the default and rescale them if necessary. For example we override it to 65.2%.

Relevant Info

This is blocking us from upgrading to JSSDK 4.28 since they recently have refactored a couple widgets to use CalciteIcon components. We can't override any of these that are nested in other Calcite components due to the shadow dom.
Please look at channel discussion here

We use Calcite Icons (just the icons) ourselves and we don't have any issues with their sizes and we'd like the consistent with any CalciteIcon components being used in the JSSDK.

Which Component

CalciteIcon

Example Use Case

There are cases where websites override the base size for rem to 65.2%, which is what we currently do.
Here's a code pen of a JSSDK example.
https://codepen.io/meescool/pen/gOZQEja

image

Priority impact

p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS StoryMaps
@meescool meescool added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Oct 13, 2023
@github-actions github-actions bot added ArcGIS StoryMaps Issues logged by ArcGIS StoryMaps team members impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Oct 13, 2023
@jcfranco jcfranco added estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed needs triage Planning workflow - pending design/dev review. labels Oct 13, 2023
@jcfranco jcfranco added the low risk Issues with low risk for consideration in low risk milestones label Oct 13, 2023
@jcfranco
Copy link
Member

We'll be updating our icon component to scale based on icon asset scales (16px, 24px and 32px) and not use rems. Scale overrides will not be pursued at this time.

@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 13, 2023
driskull added a commit that referenced this issue Oct 13, 2023
@driskull
fix(icon): use pixel sizes for icons. #8006
10c2921
@driskull driskull mentioned this issue Oct 13, 2023
Merged
driskull added a commit that referenced this issue Oct 13, 2023
@driskull
fix(icon): use pixel sizes for icons (#8009)
49085d5 
**Related Issue:** #8006

## Summary

- Use fixed pixel sizes for icons
- Add screenshot test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 13, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned driskull Oct 13, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 16, 2023
@geospatialem
Copy link
Member

Verified in 1.9.3-next.2

image

@oevans
Copy link
Member

oevans commented Oct 16, 2023

Thanks for getting this in so quickly! Is there a timeline for when JSSDK 4.28 builds (rc3, I guess?) will be updated with this?

@driskull
Copy link
Member

Hey @oevans, I'm not sure. We haven't released with this yet and I'm not sure when the SDK plans on upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS StoryMaps Issues logged by ArcGIS StoryMaps team members enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone low risk Issues with low risk for consideration in low risk milestones p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

No branches or pull requests
5 participants
@jcfranco @driskull @oevans @geospatialem @meescool