Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min/max to input time picker (like date picker) #8065

Closed
2 of 5 tasks
JonUihlein opened this issue Oct 26, 2023 · 3 comments
Closed
2 of 5 tasks

Add min/max to input time picker (like date picker) #8065

JonUihlein opened this issue Oct 26, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-06-25 - Jun ...

Comments

@JonUihlein
Copy link

Check existing issues

Description

Add min and max properties to <calcite-input-time-picker> that act like the min and max properties on <calcite-input-date-picker>. I don't think minAsDate or maxAsDate make much sense for times, so all we need is min and max.

Right now, we have to do our own validation for times in a given range, when this is handled automatically for us in the date picker.

Acceptance Criteria

min and max properties added to <calcite-input-time-picker>

Relevant Info

No response

Which Component

calcite-input-time-picker

Example Use Case

Same use-case as <calcite-input-date-picker> which already has these properties.

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@JonUihlein JonUihlein added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Oct 26, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Oct 26, 2023
@nwhittaker
Copy link
Contributor

Also interested in this for Field Maps.

@geospatialem geospatialem added the ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. label May 9, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. labels May 9, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels May 9, 2024
@benelan benelan mentioned this issue Jun 25, 2024
Merged
benelan added a commit that referenced this issue Jun 25, 2024
@benelan
feat(input-date-picker, input-time-picker): support form validation f…
38fd878 
…or min/max constraints (#9677)

**Related Issue:** #8065, #9282

## Summary

- Add `min` and `mix` properties to `calcite-input-time-picker`

- Add form validation support for `min` and `max` constraints to
`calcite-input-time-picker` and `calcite-input-date-picker`
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned benelan Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jun 25, 2024

🍍 Verified https://codepen.io/benelan/pen/VwOGwZy?editors=1010

@DitwanP DitwanP closed this as completed Jun 25, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
5 participants
@nwhittaker @JonUihlein @geospatialem @benelan @DitwanP