Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stepper-item: Remove unused messages #8223

Closed
2 of 5 tasks
anveshmekala opened this issue Nov 20, 2023 · 2 comments
Closed
2 of 5 tasks

stepper-item: Remove unused messages #8223

anveshmekala opened this issue Nov 20, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Milestone
2023 November Pri...

Comments

@anveshmekala
Copy link
Contributor

anveshmekala commented Nov 20, 2023 •
edited

Check existing issues

Description

Currently, previousStep and nextStep message strings are not used in the component which are added as part of #7918 and they are moved into stepper after the spec discussions.

Acceptance Criteria

Remove previousStep and nextStep message strings from locale bundles.

Relevant Info

No response

Which Component

calcite-stepper-item

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@anveshmekala anveshmekala added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. breaking change Issues and pull requests with code changes that are not backwards compatible. and removed 0 - new New issues that need assignment. labels Nov 20, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Nov 20, 2023
@anveshmekala anveshmekala removed needs triage Planning workflow - pending design/dev review. calcite-components Issues specific to the @esri/calcite-components package. labels Nov 20, 2023
@anveshmekala anveshmekala self-assigned this Nov 20, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Nov 20, 2023
@anveshmekala anveshmekala mentioned this issue Nov 20, 2023
Merged
@anveshmekala anveshmekala added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone and removed impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 20, 2023
anveshmekala added a commit that referenced this issue Nov 20, 2023
@anveshmekala
feat(stepper-item)!: remove support for previousStep and nextStep in …
213b31d 
…messages (#8222)

**Related Issue:** #8223 

## Summary
BREAKING CHANGE: Removed `previousStep` and `nextStep` in messages. They
are not available for overriding via `messageOverrides`
@anveshmekala anveshmekala added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 20, 2023
@geospatialem
Copy link
Member

Verified the translations are no longer present on the main branch.

This was referenced Nov 21, 2023
Closed
Merged
anveshmekala added a commit that referenced this issue Nov 21, 2023
@anveshmekala
refactor(stepper-item)!: no longer supports previousStep and nextStep…
3d689ac 
… messages (#8234)

**Related Issue:** #8223 

## Summary
BREAKING CHANGE: Removed `previousStep` and `nextStep` in messages. They
are not available for overriding via `messageOverrides`
benelan pushed a commit that referenced this issue Nov 29, 2023
@anveshmekala @benelan
refactor(stepper-item)!: no longer supports previousStep and nextStep…
dee36eb 
… messages (#8234)

**Related Issue:** #8223 

## Summary
BREAKING CHANGE: Removed `previousStep` and `nextStep` in messages. They
are not available for overriding via `messageOverrides`
benelan pushed a commit that referenced this issue Dec 1, 2023
@anveshmekala @benelan
refactor(stepper-item)!: no longer supports previousStep and nextStep…
4832281 
… messages (#8234)

**Related Issue:** #8223 

## Summary
BREAKING CHANGE: Removed `previousStep` and `nextStep` in messages. They
are not available for overriding via `messageOverrides`
benelan pushed a commit that referenced this issue Dec 1, 2023
@anveshmekala @benelan
refactor(stepper-item)!: no longer supports previousStep and nextStep…
f1eb1d2 
… messages (#8234)

**Related Issue:** #8223 

## Summary
BREAKING CHANGE: Removed `previousStep` and `nextStep` in messages. They
are not available for overriding via `messageOverrides`
benelan pushed a commit that referenced this issue Dec 2, 2023
@anveshmekala @benelan
refactor(stepper-item)!: no longer supports previousStep and nextStep…
331aafb 
… messages (#8234)

**Related Issue:** #8223 

## Summary
BREAKING CHANGE: Removed `previousStep` and `nextStep` in messages. They
are not available for overriding via `messageOverrides`
@geospatialem geospatialem added this to the 2023 November Priorities milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @anveshmekala