Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListItem: Add dragDisabled property #8284

Closed
2 of 6 tasks
driskull opened this issue Nov 28, 2023 · 2 comments
Closed
2 of 6 tasks

ListItem: Add dragDisabled property #8284

driskull opened this issue Nov 28, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2023 December Pri...

Comments

@driskull
Copy link
Member

Check existing issues

Description

SortableJS has an option to filter or prevent dragging on an individual item. It would be good to have a way to prevent dragging easily on an item.

Acceptance Criteria

Add a new property to prevent dragging on an individual item

Relevant Info

No response

Which Component

ListItem

Example Use Case

<calcite-list-item drag-disabled></calcite-list-item>

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 28, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Nov 28, 2023
driskull added a commit that referenced this issue Nov 28, 2023
@driskull
feat(list-item): Add dragDisabled property. #8284
c704ac1
@driskull driskull mentioned this issue Nov 28, 2023
Merged
@driskull driskull self-assigned this Nov 28, 2023
@driskull driskull added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 28, 2023
@driskull driskull added this to the 2023 December Priorities milestone Nov 28, 2023
driskull added a commit that referenced this issue Nov 29, 2023
@driskull
feat(list-item): Add dragDisabled property (#8285)
f091f26 
**Related Issue:** #8284

## Summary

- Adds dragDisabled property
- Adds interface for SortableItem with the dragDisabled property
- Updates SortableComponent to filter items with the `drag-disabled`
attribute
- Sets the `handle` component to disabled when `dragDisabled` is true.
- Adds screenshot test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 1, 2023
@geospatialem
Copy link
Member

Verified in 1.12.0-next.6 with the following:

<calcite-list drag-enabled>
  <calcite-list-item drag-disabled label="Hiking trails" description="Designated routes for hikers to use." value="hiking-trails">
    <calcite-action slot="actions-end" icon="layer" text="Trails layer"></calcite-action>
  </calcite-list-item>
  <calcite-list-item label="Waterfalls" description="Vertical drops from a river." value="waterfalls">
    <calcite-action slot="actions-end" icon="layer" text="Waterfalls layer"></calcite-action>
  </calcite-list-item>
  <calcite-list-item label="Rivers" description="Large naturally flowing watercourses." value="rivers">
    <calcite-action slot="actions-end" icon="layer" text="Rivers layer"></calcite-action>
  </calcite-list-item>
</calcite-list>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP