Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Logo - using wrong icon color with href #8482

Closed
1 of 6 tasks
jgrayson-apl opened this issue Dec 21, 2023 · 3 comments
Closed
1 of 6 tasks

Navigation Logo - using wrong icon color with href #8482

jgrayson-apl opened this issue Dec 21, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design-tokens Issues requiring design tokens. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-02-27 - Feb ...

Comments

@jgrayson-apl
Copy link

jgrayson-apl commented Dec 21, 2023 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

Related Issue #1: The icon color of the calcite-navigation-logo component changes to reflect link-like colors when a href attribute is present. Out of scope - refer to #8482 (comment)
Related Issue #2: the calcite-navigation-logo component still uses --calcite-ui-icon-color

We don't want the icon color to change just because we add a href attribute... it completely goes against what what we expect. Additionally, we can't use the new --calcite-color-icon-color to override as it still uses the older CSS variable.

Expected Behavior

I would expect the calcite-navigation-logo to not change the icon color just because we add a href attribute, and if that is the 'correct' undesired behavior, then at least I'd like to use the newer CSS variables to fix do this.

Reproduction Sample

https://codepen.io/john-grayson/pen/XWGWXLZ

Reproduction Steps

  1. remove href attribute from calcite-navigation-logo to see how icon should look
  2. uncomment css override to see how it still uses --calcite-ui-icon-color

Reproduction Version

2.0.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@jgrayson-apl jgrayson-apl added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 21, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Dec 21, 2023
@macandcheese macandcheese added the design-tokens Issues requiring design tokens. label Dec 21, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels Jan 11, 2024
@geospatialem geospatialem mentioned this issue Jan 11, 2024
Open
7 tasks
@geospatialem
Copy link
Member

Updated the request above, as the --calcite-ui-icon-color css var/token will remain. More details below:

The icon color of the calcite-navigation-logo component changes to reflect link-like colors when a href attribute is present.

Will work towards addressing in a future milestone. The estimate is based solely on this update.

the calcite-navigation-logo component still uses --calcite-ui-icon-color

Working towards leaving as-is, as the above in alignment with design tokens and is out of scope for the issue.

@geospatialem geospatialem changed the title Navigation Logo - wrong icon color with href and still using --calcite-ui-icon-color Navigation Logo - using wrong icon color with href Jan 11, 2024
@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 11, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jan 29, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 23, 2024
@anveshmekala anveshmekala mentioned this issue Feb 23, 2024
Merged
anveshmekala added a commit that referenced this issue Feb 23, 2024
@anveshmekala
fix(navigation-logo): no longer changes icon color when href is par…
16d456f 
…sed (#8830)

**Related Issue:** #8482 

## Summary

Fixes change of icon color in `navigation-logo` when `href` attribute is
parsed.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 23, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Feb 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 26, 2024
@geospatialem
Copy link
Member

Verified in 2.6.0-next.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design-tokens Issues requiring design tokens. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-02-27 - Feb Maintenance Release
Development

No branches or pull requests
5 participants
@macandcheese @geospatialem @jgrayson-apl @DitwanP @anveshmekala