Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[combobox] combobox filterDisabled item disappears when textLabel changes #8609

Closed
2 of 6 tasks
ptmdmusique opened this issue Jan 15, 2024 · 4 comments
Closed
2 of 6 tasks

[combobox] combobox filterDisabled item disappears when textLabel changes #8609

ptmdmusique opened this issue Jan 15, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-06-25 - Jun ...

Comments

@ptmdmusique
Copy link
Contributor

Check existing issues

Actual Behavior

The calcite-combobox-item with filterDisabled turned on will disappear if we change the textLabel props dynamically when watching for calciteComboboxFilterChange

combobox

Expected Behavior

Such items should still be when the textLabel changed

One use case is when we want to show Create new folder text by default and when there is no filter result found, we will show No result, create <filter text> name?

Reproduction Sample

https://codepen.io/ptmdmusique/pen/bGZgaoX?editors=1000

Reproduction Steps

  1. Open codepen
  2. Click on the filter and start typing
  3. Notice when the item is still there when start typing the first few characters but then disappears

Reproduction Version

~2.1.0

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@ptmdmusique ptmdmusique added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 15, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Online Issues logged by ArcGIS Online team members. labels Jan 15, 2024
@geospatialem geospatialem added design Issues that need design consultation prior to development. p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Feb 7, 2024
@brittneytewks brittneytewks added this to the Design Backlog milestone Feb 8, 2024
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Feb 8, 2024
@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed design Issues that need design consultation prior to development. labels Feb 8, 2024
@geospatialem geospatialem mentioned this issue Feb 8, 2024
Open
6 tasks
@geospatialem
Copy link
Member

Created #8707, which considers an empty state of the component - separate from the bug reported above.

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@jcfranco
Copy link
Member

The original issue was fixed by #7212 (see updated repro case).

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 24, 2024
@geospatialem
Copy link
Member

Verified in 2.10.0-next.8 with https://codepen.io/jcfranco/pen/OJYEXLK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @ptmdmusique @DitwanP @brittneytewks