Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Combobox] Make filter text value accessible in the code #7212

Closed
shellchulx opened this issue Jun 22, 2023 · 3 comments
Closed

[Combobox] Make filter text value accessible in the code #7212

shellchulx opened this issue Jun 22, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Enterprise Issues logged by ArcGIS Enterprise team members c-combobox Issues that pertain to the calcite-combobox and related components enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-06-25 - Jun ...

Comments

@shellchulx
Copy link

shellchulx commented Jun 22, 2023 •
edited
Loading

Description

The document has defined an event calciteComboboxFilterChange that is fired when text is added to filter the options list, but looks like the filter text is not accessible in the code.

The only way is through the shadowRoot.querySelect but it is not the best practice
const text = this.comboboxElement.shadowRoot.querySelector<HTMLCalciteInputElement>("input").value;

https://github.com/Esri/calcite-components/tree/master/packages/calcite-components/src/components/combobox#events

cc @BlakeStearman

Acceptance Criteria

There is a prop for the filtered text in combobox

Relevant Info

No response

Which Component

calcite-combobox

Example Use Case

There's no way to return what the filter text currently is from a calcite-combobox? For example the gis in the screenshot.

image

Priority impact

p4 - not time sensitive

Esri team

ArcGIS Enterprise
@shellchulx shellchulx added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jun 22, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive ArcGIS Enterprise Issues logged by ArcGIS Enterprise team members labels Jun 22, 2023
@geospatialem geospatialem changed the title Make filter text accessible in the code [Combobox] Make filter text value accessible in the code Jun 27, 2023
@geospatialem geospatialem added the c-combobox Issues that pertain to the calcite-combobox and related components label Jun 27, 2023
@geospatialem
Copy link
Member

geospatialem commented Jun 27, 2023 •
edited
Loading

This also surfaced in a Community post on 6/26/2023.

@JonnyDawe JonnyDawe mentioned this issue Aug 6, 2023
Open
9 tasks
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels May 28, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 28, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 4, 2024
This was referenced Jun 17, 2024
Closed
Merged
jcfranco added a commit that referenced this issue Jun 21, 2024
@jcfranco
feat(combobox): add filterText prop (#9654)
01d01de 
*Related Issue:** #7212

## Summary

Adds `filterText` to allow dynamic access to filter text.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 21, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jun 21, 2024

🍬 Verified locally on dev
image

@DitwanP DitwanP closed this as completed Jun 21, 2024
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jun 21, 2024
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label Jun 21, 2024
This was referenced Jun 24, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Enterprise Issues logged by ArcGIS Enterprise team members c-combobox Issues that pertain to the calcite-combobox and related components enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @shellchulx @DitwanP