Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[input-time-zone] Allow to show UTC instead of GMT with the input time zone picker offset mode #8716

Closed
2 of 6 tasks
fendiaoxiaoshuazi opened this issue Feb 9, 2024 · 7 comments
Closed
2 of 6 tasks

[input-time-zone] Allow to show UTC instead of GMT with the input time zone picker offset mode #8716

fendiaoxiaoshuazi opened this issue Feb 9, 2024 · 7 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Survey123 Issues logged by ArcGIS Survey123 team members. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-06-25 - Jun ...

Comments

@fendiaoxiaoshuazi
Copy link

fendiaoxiaoshuazi commented Feb 9, 2024 •
edited by jcfranco
Loading

Check existing issues

Description

The current input time zone offset mode only allow to show GMT. Is it possible to support showing UTC as an option.

Acceptance Criteria

Support showing UTC as an option.

Relevant Info

No response

Which Component

calcite-input-time-zone

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Survey123
@fendiaoxiaoshuazi fendiaoxiaoshuazi added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Feb 9, 2024
@github-actions github-actions bot added ArcGIS Survey123 Issues logged by ArcGIS Survey123 team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Feb 9, 2024
@jcfranco
Copy link
Member

jcfranco commented Mar 6, 2024

@fendiaoxiaoshuazi Thanks for submitting this issue. Would you mind sharing more details behind this request? Is this about enhancing the existing "offset" mode or would this need to introduce a new mode that mainly displays UTC options a certain way?

@jcfranco jcfranco added the need more info Issues that are missing information and/or a clear, actionable description. label Mar 6, 2024
@fendiaoxiaoshuazi
Copy link
Author

fendiaoxiaoshuazi commented Mar 11, 2024 •
edited
Loading

Hi, @jcfranco, we would like an enhancement to the existing "offset" mode. Currently, the "offset" mode can only show "GMT", and we would like an option to switch "GMT +/- *" to "UTC +/- *".
image

Like the time zone picker of Scene Viewer, and Windows time zone picker
image
image

@fendiaoxiaoshuazi
Copy link
Author

fendiaoxiaoshuazi commented Mar 22, 2024 •
edited
Loading

Currently, Survey123 connect and field app use the UTC for the time picker. The web app utilizes the Calcite input-time-zone show GMT. Therefore, we need the UTC mode in the Calcite input-time-zone to make them consistent.

Here are the reasons why we chose UTC:

  • According to I18N team

The general guideline for all Esri products is to follow UTC, not GMT. So if you display UTC – you’re good and don’t need to change anything.

@jcfranco
Copy link
Member

Belated thanks for the info, @fendiaoxiaoshuazi!

Adding related issue: #9018.

@jcfranco jcfranco removed the need more info Issues that are missing information and/or a clear, actionable description. label May 22, 2024
This was referenced May 25, 2024
Open
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 21, 2024
@jcfranco jcfranco self-assigned this Jun 21, 2024
@jcfranco jcfranco added estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed needs triage Planning workflow - pending design/dev review. labels Jun 21, 2024
@jcfranco jcfranco added this to the 2024-06-25 - Jun Release milestone Jun 21, 2024
@jcfranco
Copy link
Member

Moved to the June release as this is needed for #9018. cc @geospatialem

jcfranco added a commit that referenced this issue Jun 25, 2024
@jcfranco
feat(input-time-zone): add offsetStyle prop (#9426)
dbc6c81 
**Related Issue:** #8716

## Summary

Adds `offsetStyle` prop to specify whether offset should always use
`UTC` or `GMT` for the offset label instead of using the user's locale.
Valid options are:

  * `"user"` (default) uses `UTC` or `GMT` depending on the user's locale,
   * `"gmt"` always uses `GMT`, and
   * `"utc"` always uses `UTC`.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jun 25, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 25, 2024
@geospatialem
Copy link
Member

Verified in 2.10.0-next.10 with the new offset-style attribute (offsetStyle prop) with the following values:

  • "user" (default)
  • "gmt" and
  • "utc"

For example:

<calcite-input-time-zone offset-style="utc"></calcite-input-time-zone>

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Survey123 Issues logged by ArcGIS Survey123 team members. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @fendiaoxiaoshuazi @DitwanP