Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List Item] - calcite-select becomes unresponsive in a calcite-list-item if drag-disabled is true #8954

Closed
2 of 6 tasks
sagewall opened this issue Mar 18, 2024 · 3 comments
Closed
2 of 6 tasks

[List Item] - calcite-select becomes unresponsive in a calcite-list-item if drag-disabled is true #8954

sagewall opened this issue Mar 18, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2024-03-26 - Mar ...

Comments

@sagewall
Copy link

Check existing issues

Actual Behavior

A calcite select component becomes unresponsive when placed in a calcite-list-item with drag-disabled set to true.

Expected Behavior

The calcite select component should behave and respond normally.

Reproduction Sample

https://codepen.io/sagewall/pen/eYogBjN

Reproduction Steps

  1. Open this codepen
  2. Observe how the calcite select in the test2 list item doesn't respond normally.

Reproduction Version

2.6.0

Relevant Info

Doesn't seem to be browser or OS dependent

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

This is impacting custom list item content the LayerList widget in the JavaScript Maps SDK.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@sagewall sagewall added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Mar 18, 2024
@sagewall
Copy link
Author

cc @driskull

@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels Mar 18, 2024
driskull added a commit that referenced this issue Mar 18, 2024
@driskull
fix(list, list-item): calcite-select becomes unresponsive in a calcit…
df78e37 
…e-list-item if drag-disabled is true #8954
@driskull driskull mentioned this issue Mar 18, 2024
Merged
@driskull driskull self-assigned this Mar 18, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 18, 2024
@driskull driskull added this to the 2024-03-26 - Mar Release milestone Mar 18, 2024
driskull added a commit that referenced this issue Mar 19, 2024
@driskull
fix(list, list-item): calcite-select becomes unresponsive in a list-i…
e408c62 
…tem if drag-disabled is true (#8957)

**Related Issue:** #8954

## Summary

- Sortablejs by default calls `event.preventDefault()` because the
option `preventOnFilter` is true by default.
- This affects any elements slotted within the `drag-disabled` list
item.
- In order to fix this, we move the `filter` selector to just the
`calcite-handle` instead of the whole `list-item`.

```js
filter: ".ignore-elements",  // Selectors that do not lead to dragging (String or Function)
preventOnFilter: true, // Call `event.preventDefault()` when triggered `filter`
```
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Mar 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned driskull Mar 19, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 21, 2024
@geospatialem
Copy link
Member

Verified in 2.7.0-next.11

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2024-03-26 - Mar Release
Development

No branches or pull requests
4 participants
@driskull @sagewall @geospatialem @DitwanP