Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List]: update single-select icons #9174

Open
2 of 8 tasks
ashetland opened this issue Apr 23, 2024 · 1 comment
Open
2 of 8 tasks

[List]: update single-select icons #9174

ashetland opened this issue Apr 23, 2024 · 1 comment
Labels
0 - new New issues that need assignment. c-list Issues that pertain to the calcite-list component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive visual changes Issues with visual changes that are added for consistency, but are not backwards compatible

Comments

@ashetland
Copy link

Check existing issues

Description

Update single-select icons to align with Table. List was previously updated to match Dropdown, but the small dot is less ideal for content-rich settings where the selection state needs to be more prominent. Small dots are also commonly used to indicate activity.

While not a breaking change by itself, this should be paired with #7100 and #9173.

Acceptance Criteria

For selection-appearance="icon" and selection-mode="single"`:

  • unselected should use icon="circle"
  • selected should use "icon="circle-f"

image

Relevant Info

No response

Which Component

List
List Item

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 23, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Apr 23, 2024
@ashetland
Copy link
Author

cc @driskull

@geospatialem geospatialem added breaking change Issues and pull requests with code changes that are not backwards compatible. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 26, 2024
@macandcheese macandcheese added the c-list Issues that pertain to the calcite-list component label May 1, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Jun 18, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 18, 2024
@jcfranco jcfranco added visual changes Issues with visual changes that are added for consistency, but are not backwards compatible and removed breaking change Issues and pull requests with code changes that are not backwards compatible. labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. c-list Issues that pertain to the calcite-list component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Development

No branches or pull requests

4 participants