Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested child list items are displayed briefly until component recognizes them and adds the caret and hides them #9400

Closed
2 of 6 tasks
sagewall opened this issue May 22, 2024 · 3 comments
Closed
2 of 6 tasks

Nested child list items are displayed briefly until component recognizes them and adds the caret and hides them #9400

sagewall opened this issue May 22, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Experience Builder Issues logged by ArcGIS Experience Builder team members ArcGIS Instant Apps Issues logged by ArcGIS Instant Apps team members. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-06-25 - Jun ...

Comments

@sagewall
Copy link

sagewall commented May 22, 2024 •
edited
Loading

Check existing issues

Actual Behavior

Nested child list items are displayed briefly until component recognizes them and adds the caret and hides them. This results in a flickering behavior. The flickering is more apparent in complex lists like the JavaScript SDK LayerList.

Expected Behavior

The child list items are hidden until the caret unhides them.

Reproduction Sample

https://codepen.io/sagewall/pen/GRaqWya

Reproduction Steps

  1. Expand the "Catalog layer with a group layer" list item
  2. Expand the "Layers In View" list item
  3. Notice the flickering as the list items briefly appear and then hide
  4. Expand the "Testing Tooltip input" list item
  5. Notice the flickering

Reproduction Version

2.8.3

Relevant Info

Seems independent of browser and OS

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

This is impacting the JavaScript API and all the Esri web applications that use it such as Map Viewer, Instant Apps and Experience Builder.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@sagewall sagewall added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels May 22, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels May 22, 2024
@geospatialem geospatialem added ArcGIS Experience Builder Issues logged by ArcGIS Experience Builder team members ArcGIS Instant Apps Issues logged by ArcGIS Instant Apps team members. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels May 22, 2024
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone May 28, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 28, 2024
driskull added a commit that referenced this issue May 30, 2024
@driskull
fix(list-item): hide nested list items by default. #9400
6634dc0
@driskull driskull mentioned this issue May 30, 2024
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 6, 2024
@jcfranco
Copy link
Member

jcfranco commented Jun 6, 2024 •
edited
Loading

Moving this to the June milestone since @driskull has a PR standing by. 🎉 cc @geospatialem

driskull added a commit that referenced this issue Jun 6, 2024
@driskull
fix(list-item): hide nested list items by default (#9474)
fb06ef9 
**Related Issue:** #9400

## Summary

- Hides nested/indented list items by default
- Removes unnecessary div
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 6, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 6, 2024
@geospatialem
Copy link
Member

Verified in 2.10.0-next.0:

verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Experience Builder Issues logged by ArcGIS Experience Builder team members ArcGIS Instant Apps Issues logged by ArcGIS Instant Apps team members. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
5 participants
@jcfranco @driskull @sagewall @geospatialem @DitwanP