Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color Picker] Adjust component's scope and color swatch sizing #9412

Closed
2 of 8 tasks
geospatialem opened this issue May 24, 2024 · 3 comments
Closed
2 of 8 tasks

[Color Picker] Adjust component's scope and color swatch sizing #9412

geospatialem opened this issue May 24, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2024-06-25 - Jun ...

Comments

@geospatialem
Copy link
Member

geospatialem commented May 24, 2024 •
edited by ashetland
Loading

Check existing issues

Description

Improve the color-picker design with the alpha channel and color swatch, where:

  1. The color swatch size is smaller when alpha-channel is not used
  2. The scope thumb is also reduced in size to match the slider heights

Acceptance Criteria

  • Reduce size of scope to 14px circles to match slider height (applies to all scales)
  • When alpha-channel is not used, reduce sampled color swatch to match size of saved color swatches: 20px for small scale and 24 px for medium scale. No changes are required for large scale.

Relevant Info

Which Component

color-picker

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - low Issue is non core or affecting less that 10% of people using the library 0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible labels May 24, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels May 24, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels May 24, 2024
@geospatialem geospatialem mentioned this issue May 24, 2024
Open
4 tasks
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 4, 2024
@jcfranco jcfranco mentioned this issue Jun 5, 2024
Merged
jcfranco added a commit that referenced this issue Jun 12, 2024
@jcfranco
feat(color-picker): adjust thumb and color preview sizes to follow up…
41dc551 
…dated spec (#9523)

**Related Issue:** #9412

## Summary

This decreases the size of thumbs and uses the component's scale for the
color preview when alpha channel is not displayed.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jun 12, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Jun 12, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP