Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Block Section] When toggle-display is set to "switch" unable to toggle #9454

Closed
2 of 6 tasks
geospatialem opened this issue May 29, 2024 · 2 comments
Closed
2 of 6 tasks

[Block Section] When toggle-display is set to "switch" unable to toggle #9454

geospatialem opened this issue May 29, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-06-25 - Jun ...

Comments

@geospatialem
Copy link
Member

Check existing issues

Actual Behavior

A regression was introduced to block-section, where when toggle-display is set to "switch" unable to toggle.

issue

Expected Behavior

Toggle behavior for both the "switch" and "button"

before

Reproduction Sample

https://codepen.io/geospatialem/pen/BaepzdW

Reproduction Steps

  1. Open the sample
  2. Try to collapse/expand the block-section with the toggle switch
  3. Observe no change
  4. If you change to the button switch or 2.8.4 observe the switch works as-intended

Reproduction Version

2.9.0

Relevant Info

Possibly introduced via #9194, does not impact the default toggle ("button").

Regression?

2.8.4

Priority impact

impact - p1 - need for current milestone

Impact

High, to accommodate folks using the "switch" toggle as soon as possible.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. regression Issues that are caused by changes in a release, but were working before that. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. labels May 29, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels May 29, 2024
@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels May 29, 2024
@jcfranco jcfranco self-assigned this May 30, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 30, 2024
@jcfranco jcfranco mentioned this issue May 30, 2024
Merged
jcfranco added a commit that referenced this issue Jun 4, 2024
@jcfranco
fix(block-section): restore block toggling when clicking on the heade…
519a11c 
…r switch (#9472)

**Related Issue:** #9454

## Summary

Fixes toggling issue caused by moving switch outside toggle container.

This regression was introduced by #9194.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 6, 2024
@geospatialem
Copy link
Member Author

Verified in 2.10.0-next.0:

verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP