fix(pagination): use semantic internal elements #9479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
added
the
pr ready for visual snapshots
jcfranco
approved these changes
May 31, 2024
| > | ||
| <calcite-icon flipRtl icon={ICONS.previous} scale={getIconScale(this.scale)} /> | ||
| </button> | ||
| <li> |
There was a problem hiding this comment.
Can you extract the list item rendering to a separate function and reuse?
There was a problem hiding this comment.
I could create a functional component for a li but that seems a little overkill for this since its just a list item with a class.
packages/calcite-components/src/components/pagination/pagination.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/pagination/pagination.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/pagination/pagination.e2e.ts
Outdated
Show resolved
Hide resolved
driskull
commented
May 31, 2024
driskull
added
pr ready for visual snapshots
jcfranco
reviewed
May 31, 2024
| const page = await newE2EPage(); | ||
| await page.setContent(`<calcite-pagination total-items="10" page-size="1"></calcite-pagination>`); | ||
| const list = await page.find(`calcite-pagination >>> .${CSS.list}`); | ||
| expect(list).not.toBeNull(); |
There was a problem hiding this comment.
Can you also assert on the element types? Maybe we can the following test util:
function assertElementTag(element: E2EElement, tag: keyof HTMLElementTagNameMap): void {
return expect(element.tagName.toLowerCase()).toBe(tag);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7804
Summary