Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color-picker): adjust thumb and color preview sizes to follow updated spec #9523

Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jun 5, 2024

Related Issue: #9412

Summary

This decreases the size of thumbs and uses the component's scale for the color preview when alpha channel is not displayed.

@jcfranco jcfranco requested a review from a team as a code owner June 5, 2024 17:39
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jun 5, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 5, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 7, 2024
@jcfranco jcfranco requested a review from ashetland June 7, 2024 23:26
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 8, 2024
@benelan benelan changed the base branch from main to dev June 10, 2024 09:08
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 11, 2024
@ashetland
Copy link

😍

@jcfranco jcfranco merged commit 41dc551 into dev Jun 12, 2024
12 checks passed
@jcfranco jcfranco deleted the jcfranco/9412-update-color-picker-thumbs-and-preview-swatch-sizes branch June 12, 2024 06:23
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants