-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include version in global config #9536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
|
||
/** | ||
* Contains the version of the Calcite components. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can document this as readOnly somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add @readonly
to the interface doc, but it won't show up in a readme nor the docs-json.json
file. @geospatialem @DitwanP @macandcheese Do you have any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
## Summary - Remove Chromatic from `main`, since it will already have ran on `dev`. - Fix the scheduled update jobs, which where still creating PRs targeting `main`. Thankfully I left the 6 approvals rule because I definitely tried to merge those with `gh` 😅 - Change the branch of code URLs from `main` to `dev`. Side note: maybe we could use the rollup plugin from #9536 to pin the version tag in the API reference code links. That way docs-json will point to the actual version's code instead of whatever is currently on `dev` or `main`.
Related Issue: #8848
Summary
This updates the globalScript to stamp the version onto an existing global calciteConfig var and will create one if not defined.