feat: include version in global config #9536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
skip visual snapshots
jcfranco
requested review from
benelan,
driskull,
geospatialem and
a team
as code owners
driskull
approved these changes
Jun 10, 2024
|
|
||
| /** | ||
| * Contains the version of the Calcite components. | ||
| */ |
There was a problem hiding this comment.
maybe we can document this as readOnly somehow?
There was a problem hiding this comment.
We can add @readonly to the interface doc, but it won't show up in a readme nor the docs-json.json file. @geospatialem @DitwanP @macandcheese Do you have any suggestions?
benelan
added a commit
that referenced
this pull request
Jun 18, 2024
## Summary - Remove Chromatic from `main`, since it will already have ran on `dev`. - Fix the scheduled update jobs, which where still creating PRs targeting `main`. Thankfully I left the 6 approvals rule because I definitely tried to merge those with `gh` 😅 - Change the branch of code URLs from `main` to `dev`. Side note: maybe we could use the rollup plugin from #9536 to pin the version tag in the API reference code links. That way docs-json will point to the actual version's code instead of whatever is currently on `dev` or `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8848
Summary
This updates the globalScript to stamp the version onto an existing global calciteConfig var and will create one if not defined.