Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

before open/close events emitted immediately after transition #9559

Closed
2 of 6 tasks
macandcheese opened this issue Jun 11, 2024 · 3 comments
Closed
2 of 6 tasks

before open/close events emitted immediately after transition #9559

macandcheese opened this issue Jun 11, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-06-25 - Jun ...

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Actual Behavior

On dev - the Modal has the incorrect animation:

Screen.Recording.2024-06-11.at.10.04.44.AM.mov

Expected Behavior

The animation should behave as it does in 2.9

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/dyEVmam?editors=1000

Reproduction Steps

  1. Open Codepen
  2. Open Model
  3. See difference in animation

Reproduction Version

Unreleased

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

cc @jcfranco

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 11, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jun 11, 2024
@jcfranco jcfranco added the regression Issues that are caused by changes in a release, but were working before that. label Jun 11, 2024
@jcfranco jcfranco self-assigned this Jun 11, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 11, 2024
@jcfranco jcfranco added this to the 2024-06-25 - Jun Release milestone Jun 11, 2024
@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed p - medium Issue is non core or affecting less that 60% of people using the library labels Jun 11, 2024
@jcfranco
Copy link
Member

jcfranco commented Jun 11, 2024 •
edited
Loading

This was introduced by bb45bdb. It looks like it affects the openClose util and events will fire out of order. Bumped severity and marked as a regression because of this.

@jcfranco jcfranco mentioned this issue Jun 11, 2024
Merged
jcfranco added a commit that referenced this issue Jun 12, 2024
@jcfranco
fix: fix regression causing open/close events from emitting in proper…
fa5b415 
… order (#9560)

**Related Issue:** #9559

## Summary

This fixes `openCloseComponent.onToggleOpenCloseComponent` to emit
beforeOpen/Close events when the associated transition starts and emits
open/close when the transition ends.

This regression was introduced by
#9341 and would cause
`beforeOpen`/`open` or `beforeClose`/`close` to emit immediately after
another after the transition was done.

### Notable changes

* adds spec test to add coverage for `onToggleOpenCloseComponent`
* enhances `whenAnimationDone`/`whenTransitionDone` to accept callbacks
for both start and end phases
* exposes `readTask` from `openCloseComponent` to allow for stubbing
(stubbing Stencil's utility is not possible because the core module
getters are non-configurable)
* extracts animation/transition helpers for spec tests to individual
modules
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jun 12, 2024
@jcfranco jcfranco changed the title [Modal] Incorrect animation before open/close events emitted immediately after transition Jun 12, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jun 13, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Jun 13, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
4 participants
@jcfranco @macandcheese @geospatialem @DitwanP