fix: fix regression causing open/close events from emitting in proper order #9560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
pr ready for visual snapshots
github-actions
bot
added
the
bug
jcfranco
added
pr ready for visual snapshots
driskull
approved these changes
Jun 12, 2024
| @@ -1,6 +1,11 @@ | |||
| import { readTask } from "@stencil/core"; | |||
| import { whenTransitionDone } from "./dom"; | |||
|
|
|||
| /** | |||
| * Exported for testing purposes only | |||
| @@ -702,8 +720,14 @@ export async function whenTransitionOrAnimationDone( | |||
| so we fall back to it if there's no matching prop duration */ | |||
| allDurationsArray[0]; | |||
|
|
|||
| function startEndImmediately(): void { | |||
jcfranco
added
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9559
Summary
This fixes
openCloseComponent.onToggleOpenCloseComponentto emit beforeOpen/Close events when the associated transition starts and emits open/close when the transition ends.This regression was introduced by #9341 and would cause
beforeOpen/openorbeforeClose/closeto emit immediately after another after the transition was done.Notable changes
onToggleOpenCloseComponentwhenAnimationDone/whenTransitionDoneto accept callbacks for both start and end phasesreadTaskfromopenCloseComponentto allow for stubbing (stubbing Stencil's utility is not possible because the core module getters are non-configurable)