Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using calcite-tile's selected property throws type errors #9582

Closed
2 of 6 tasks
eriklharper opened this issue Jun 13, 2024 · 2 comments
Closed
2 of 6 tasks

Using calcite-tile's selected property throws type errors #9582

eriklharper opened this issue Jun 13, 2024 · 2 comments
Assignees
@DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2024-06-25 - Jun ...

Comments

@eriklharper
Copy link
Contributor

Check existing issues

Actual Behavior

When setting the selected property on a calcite-tile element, the following Typescript error occurs:

image

Expected Behavior

Users should be able to set selected for setting the initial selected state without any type/compilation errors.

Reproduction Sample

TBD

Reproduction Steps

  1. Create a Typescript app
  2. npm install @esri/calcite-components
  3. Try using calcite-tile by creating an instance of it and setting the selected property/attribute on it.
  4. Result: TS error

Reproduction Version

2.9

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@eriklharper eriklharper added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 13, 2024
@eriklharper eriklharper self-assigned this Jun 13, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jun 13, 2024
@eriklharper eriklharper mentioned this issue Jun 13, 2024
Merged
eriklharper added a commit that referenced this issue Jun 14, 2024
@eriklharper
fix(tile): expose selected property (#9583)
d15f667 
**Related Issue:** #9582

## Summary

This PR exposes `calcite-tile`'s `selected` property so that it won't
throw typescript errors when compiled. This was made internal
unintentionally as other components like `calcite-chip` expose this
property.
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. needs triage Planning workflow - pending design/dev review. labels Jun 14, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@eriklharper eriklharper added the estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. label Jun 14, 2024
@geospatialem geospatialem added this to the 2024-06-25 - Jun Release milestone Jun 20, 2024
@geospatialem geospatialem removed their assignment Jun 20, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jun 21, 2024

🍭 Verified locally on dev

@DitwanP DitwanP closed this as completed Jun 21, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
3 participants
@eriklharper @geospatialem @DitwanP