Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox: Once a value is typed in, arrow left and arrow right keys do not work #9614

Closed
2 of 6 tasks
driskull opened this issue Jun 17, 2024 · 2 comments
Closed
2 of 6 tasks

Combobox: Once a value is typed in, arrow left and arrow right keys do not work #9614

driskull opened this issue Jun 17, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-06-25 - Jun ...

Comments

@driskull
Copy link
Member

driskull commented Jun 17, 2024 •
edited
Loading

Check existing issues

Summary

Once a value is typed in, arrow left and arrow right keys do not work

Actual Behavior

Once a value is typed in, arrow left and arrow right keys do not work

Expected Behavior

ArrowRight and ArrowLeft keys work for selecting text already entered

Reproduction Sample

https://codepen.io/driskull/pen/pompmZd?editors=1000

Reproduction Steps

  1. open codepen
  2. type into combobox
  3. try to use arrow right or arrow left keys on text typed in

Reproduction Version

2.9.0

Working W3C Example/Tutorial

No response

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. a11y Issues related to Accessibility fixes or improvements. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 17, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jun 17, 2024
@driskull driskull mentioned this issue Jun 17, 2024
Closed
@driskull driskull self-assigned this Jun 18, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 18, 2024
driskull added a commit that referenced this issue Jun 18, 2024
@driskull
fix(combobox): allow arrow selection of entered text. #9614
9f8f744
@driskull driskull mentioned this issue Jun 18, 2024
Merged
@driskull driskull added estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Jun 18, 2024
@driskull driskull added this to the 2024-06-25 - Jun Release milestone Jun 18, 2024
driskull added a commit that referenced this issue Jun 21, 2024
@driskull
fix(combobox): allow arrow selection of entered text (#9629)
df5e654 
**Related Issue:** #9614

## Summary

- fix to allow arrow keys to work to navigate text. (left/right/up/down)
  - checks the selectionIndex or whether a chip is selected to do so
  - arrow up and arrow down work when no filtered items are available
- Adds test
- Adds utility function for future use
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 21, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jun 21, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Jun 21, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP