fix(list-item): Improve focus outline appearance #9653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
requested changes
Jun 20, 2024
| @@ -14,6 +14,16 @@ | |||
|
|
|||
| @include disabled(); | |||
|
|
|||
| .indent { | |||
There was a problem hiding this comment.
indent isn't a valid class on the list-item. Can this part be reverted? It should be on .nested-container. I'm guessing this was copied from a previous release.
| } | ||
|
|
||
| .nested-container--open { | ||
| @apply flex; | ||
| .nested-container--hidden { |
There was a problem hiding this comment.
This should be reverted as well.
driskull
approved these changes
Jun 20, 2024
| tr:focus { | ||
| .actions-start, | ||
| .actions-end { | ||
| inset-block: theme("spacing[0.5]"); |
There was a problem hiding this comment.
note: At some point these theme() vars will need to be updated to use calcite css vars.
| content: ""; | ||
| inline-size: theme("spacing[0]"); | ||
| z-index: theme("zIndex.header"); | ||
| background-color: theme("colors.brand"); |
There was a problem hiding this comment.
optional: Might be able to use a css var here for brand.
| @apply absolute; | ||
| content: ""; | ||
| inline-size: theme("spacing[0]"); | ||
| z-index: theme("zIndex.header"); |
There was a problem hiding this comment.
optional: Might be able to use a css var here for z-index.
josercarcamo
added
the
pr ready for visual snapshots
josercarcamo
added
pr ready for visual snapshots
benelan
added
autorelease: tagged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7538
Summary
Make list item highlight display correctly over action items.