Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list: slotted list-items that are not direct children of a list should be draggable #9663

Closed
2 of 6 tasks
DitwanP opened this issue Jun 21, 2024 · 2 comments
Closed
2 of 6 tasks
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Jun 21, 2024

Check existing issues

Actual Behavior

list-item's slotted inside a div within a list do not get drag functionality when dragging is enabled`

Expected Behavior

list-item's within a list should be draggable if it's enabled, regardless of them being direct children or not.

Reproduction Sample

https://codepen.io/Ditwan-Price/pen/YzbaRQz?editors=1000

Reproduction Steps

  1. Open codepen.
  2. Notice how the first list is cannot be dragged even though drag handles are present.
  3. Notice how the second list works as expected.
  4. These lists should behave the same way.

Reproduction Version

2.10.0-next.6

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@DitwanP DitwanP added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 21, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jun 21, 2024
@DitwanP DitwanP added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jun 21, 2024
@driskull
Copy link
Member

There is a limitation with sortablejs, the library we are currently using for drag and drop, that requires the draggable elements of a parent to be direct children. Because of this, we can't support list-item's that aren't direct children of calcite-list.

I think we can close this issue and reevaluate if it becomes a problem.

@geospatialem
Copy link
Member

Closing due to the limitation mentioned above.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants